Skip to content

op-bindings: speed up build #3116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tynes merged 1 commit into from
Jul 28, 2022
Merged

op-bindings: speed up build #3116

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions op-bindings/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,22 +18,22 @@ gas-price-oracle-deployed: gas-price-oracle-bindings
./gen_deployed_bytecode.sh GasPriceOracle bindings

l1block-bindings:
./gen_bindings.sh L1Block bindings
./gen_bindings.sh contracts/L2/L1Block.sol:L1Block bindings

l2-to-l1-message-passer-bindings:
./gen_bindings.sh L2ToL1MessagePasser bindings
./gen_bindings.sh contracts/L2/L2ToL1MessagePasser.sol:L2ToL1MessagePasser bindings

optimism-portal-bindings:
./gen_bindings.sh OptimismPortal bindings
./gen_bindings.sh contracts/L1/OptimismPortal.sol:OptimismPortal bindings

l2-output-oracle-bindings:
./gen_bindings.sh L2OutputOracle bindings
./gen_bindings.sh contracts/L1/L2OutputOracle.sol:L2OutputOracle bindings

gas-price-oracle-bindings:
./gen_bindings.sh GasPriceOracle bindings
./gen_bindings.sh contracts/L2/GasPriceOracle.sol:GasPriceOracle bindings

address-manager-bindings:
./gen_bindings.sh AddressManager bindings
./gen_bindings.sh contracts/legacy/AddressManager.sol:AddressManager bindings

mkdir:
mkdir -p bin bindings
Expand Down
13 changes: 8 additions & 5 deletions op-bindings/gen_bindings.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,11 @@ need_cmd() {
need_cmd forge
need_cmd abigen


TYPE=$1
NAME=$1
# This can handle both fully qualified syntax or just
# the name of the contract.
# Fully qualified: path-to-contract-file:contract-name
TYPE=$(echo "$NAME" | cut -d ':' -f2)
PACKAGE=$2

# Convert to lower case to respect golang package naming conventions
Expand All @@ -35,9 +38,9 @@ CWD=$(pwd)
# Build contracts
cd ${CONTRACTS_PATH}
forge build
forge inspect ${TYPE} abi > ${TEMP}/${TYPE}.abi
forge inspect ${TYPE} bytecode > ${TEMP}/${TYPE}.bin
forge inspect ${TYPE} deployedBytecode > ${CWD}/bin/${TYPE_LOWER}_deployed.hex
forge inspect ${NAME} abi > ${TEMP}/${TYPE}.abi
forge inspect ${NAME} bytecode > ${TEMP}/${TYPE}.bin
forge inspect ${NAME} deployedBytecode > ${CWD}/bin/${TYPE_LOWER}_deployed.hex

# Run ABIGEN
cd ${CWD}
Expand Down