Fixing geth submission index to not be 0 for all records#311
Closed
willmeister wants to merge 2 commits intomasterfrom
Closed
Fixing geth submission index to not be 0 for all records#311willmeister wants to merge 2 commits intomasterfrom
willmeister wants to merge 2 commits intomasterfrom
Conversation
snario
pushed a commit
that referenced
this pull request
Apr 14, 2021
…311) * remove immutable * add fallback function to deposit eth into l2 * Revert "remove immutable" This reverts commit 6e8bf7b1871b56085ce96ee73b5acbd4bd04b96c. * remove conflicting receive function Co-authored-by: George Hotz <geohot@gmail.com> Co-authored-by: smartcontracts <kelvinfichter@gmail.com>
protolambda
pushed a commit
to protolambda/optimism
that referenced
this pull request
May 1, 2022
…/docs-fix-typo
shenkeyao
referenced
this pull request
in EspressoSystems/optimism-espresso-integration
Mar 1, 2025
* test(altda): add test for altda->ethda failover * feat(batcher): altda->ethda failover when altda is down * chore: fix typos * fix(fakeDAServer): handlePut was still handling put when in failover mode * Fix logs --------- Co-authored-by: Samuel Laferriere <samlaf92@gmail.com>
QuentinI
referenced
this pull request
in EspressoSystems/optimism-espresso-integration
Mar 7, 2025
* test(altda): add test for altda->ethda failover * feat(batcher): altda->ethda failover when altda is down * chore: fix typos * fix(fakeDAServer): handlePut was still handling put when in failover mode * Fix logs --------- Co-authored-by: Samuel Laferriere <samlaf92@gmail.com>
QuentinI
referenced
this pull request
in EspressoSystems/optimism-espresso-integration
May 27, 2025
* test(altda): add test for altda->ethda failover * feat(batcher): altda->ethda failover when altda is down * chore: fix typos * fix(fakeDAServer): handlePut was still handling put when in failover mode * Fix logs --------- Co-authored-by: Samuel Laferriere <samlaf92@gmail.com>
theochap
pushed a commit
that referenced
this pull request
Jan 15, 2026
### Description Adds the missing `op-alloy-registry` to the `op-alloy` aggregator crate under the `registry` feature flag.
emhane
pushed a commit
that referenced
this pull request
Feb 4, 2026
Closes #311 Performace comparison under load test: ``` previous: 4.873750666s sorted delete: 3.278444083s sorted delete + seperate read (current as per the PR): 2.980065583s ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Makes it so all
l1_rollup_tx.index_within_submissionwill not be 0, and for rollup batches with multiple transactions, the correct number will be assigned.Metadata
Fixes
Contributing Agreement