Skip to content

contracts-bedrock: depositTransaction warning #2678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mergify merged 4 commits into from
Jun 3, 2022
Merged

contracts-bedrock: depositTransaction warning #2678

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
58326fe
contracts-bedrock: depositTransaction warning
maurelian Jun 3, 2022
f93769a
Merge branch 'develop' into m/tob-7-underspecified-deposits
mergify[bot] Jun 3, 2022
9c92c59
Merge branch 'develop' into m/tob-7-underspecified-deposits
tynes Jun 3, 2022
d37bc73
Merge branch 'develop' into m/tob-7-underspecified-deposits
mslipper Jun 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions packages/contracts-bedrock/contracts/L1/OptimismPortal.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,8 +78,11 @@ contract OptimismPortal is ResourceMetering {
}

/**
* Accepts deposits of ETH and data, and emits a TransactionDeposited event for use in deriving
* deposit transactions.
* @notice Accepts deposits of ETH and data, and emits a TransactionDeposited event for use in
* deriving deposit transactions. Note that if a deposit is made by a contract, its address will
* be aliased when retrieved using `tx.origin` or `msg.sender`. This can lead to loss of funds
* in some cases which the depositing contract may not have accounted for. Consider using the
* Bridge or CrossDomainMessenger contracts which provide additional safety assurances.
*
* @param _to The L2 destination address.
* @param _value The ETH value to send in the deposit transaction.
Expand Down