Merged
Conversation
… to process the same block twice vs risk not processing it once.
karlfloersch
approved these changes
Sep 20, 2020
Contributor
karlfloersch
left a comment
karlfloersch
left a comment
There was a problem hiding this comment.
Alright this looks great! The test coverage seems very solid and logic really doesn't feel like it should be too complex. LGTM!
| }) | ||
| }) | ||
| }) | ||
| }) |
| if (blockNumber < this.earliestBlock) { | ||
| const finalizedBlockNumber = this.getBlockFinalizedBy(blockNumber) | ||
|
|
||
| if (finalizedBlockNumber < this.earliestBlock) { |
snario
pushed a commit
that referenced
this pull request
Apr 14, 2021
protolambda
pushed a commit
to protolambda/optimism
that referenced
this pull request
May 1, 2022
shenkeyao
referenced
this pull request
in EspressoSystems/optimism-espresso-integration
Mar 1, 2025
This change deletes bad blocks at migration time, since we don't need to keep historical bad blocks and if not transformed like the other migrated blocks can lead to panics when trying to load them (which happens when a new bad block is discovered). I've tested this locally, by taking a datdir where bad blocks could be retrieved via `geth db get 0x496e76616c6964426c6f636b` and migrated it and verified that then the bad blocks cannot be retrieved which looks like this: INFO [10-28|13:00:32.736] Get operation failed error="leveldb: not found" Since the key is not present.
QuentinI
referenced
this pull request
in EspressoSystems/optimism-espresso-integration
Mar 7, 2025
This change deletes bad blocks at migration time, since we don't need to keep historical bad blocks and if not transformed like the other migrated blocks can lead to panics when trying to load them (which happens when a new bad block is discovered). I've tested this locally, by taking a datdir where bad blocks could be retrieved via `geth db get 0x496e76616c6964426c6f636b` and migrated it and verified that then the bad blocks cannot be retrieved which looks like this: INFO [10-28|13:00:32.736] Get operation failed error="leveldb: not found" Since the key is not present.
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
Zena-park
pushed a commit
to tokamak-network/optimism
that referenced
this pull request
Dec 30, 2025
…mism#267 We advise the same modifiers to be applied, ensuring that the contract is in a valid state whenever a candidate is created.
theochap
pushed a commit
that referenced
this pull request
Jan 15, 2026
### Description Adds zlib compression to the `ChannelOut`. Closes #267
theochap
pushed a commit
that referenced
this pull request
Jan 21, 2026
### Description Adds zlib compression to the `ChannelOut`. Closes #267
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Simplifies block subscription by finalizing the block X blocks ago when a block is received. Also adds more tests for the transition between syncing past blocks and current/future blocks.
Contributing Agreement