Fixing block hang on syncing empty blocks#266
Merged
willmeister merged 1 commit intomasterfrom Sep 19, 2020
Merged
Conversation
K-Ho
approved these changes
Sep 18, 2020
| const deployResult = await config.signer.sendTransaction({ | ||
| data: rawTx.data, | ||
| gasLimit: 9_500_000, | ||
| gasLimit: 7_500_000, |
Comment on lines
+123
to
+131
| while ( | ||
| (await provider.getBlockNumber()) < | ||
| blockNumber + this.confirmsUntilFinal | ||
| ) { | ||
| log.debug( | ||
| `Waiting for empty block ${blockNumber} to be final. Sleeping...` | ||
| ) | ||
| await sleep(15_000) | ||
| } |
Contributor
There was a problem hiding this comment.
do we need both cases or can we just keep this one?
Author
There was a problem hiding this comment.
No, don't need to. Was thinking maaaaaybe ethers does something better than just polling, so that's better than this? Happy to consolidate if you think though. Eventually we'll go with the "this block finalizes the block X blocks ago" approach vs the "I got a block, now wait a bunch of blocks for this block to be final" approach.
Author
There was a problem hiding this comment.
Going to ship for now but happy to change it post-merge if you'd like!
snario
pushed a commit
that referenced
this pull request
Apr 14, 2021
Co-authored-by: Kelvin Fichter <kelvinfichter@gmail.com>
protolambda
pushed a commit
to protolambda/optimism
that referenced
this pull request
May 1, 2022
…emo-merge Demo setup and fixes
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
* chore(derive): sources touchups * fix: lints
Zena-park
pushed a commit
to tokamak-network/optimism
that referenced
this pull request
Dec 30, 2025
we dont use byteToUnit256 function
theochap
pushed a commit
that referenced
this pull request
Jan 15, 2026
### Description Removes the `TryFrom` span batch for `RawSpanBatch`, inlining the coercion into a `to_raw_span_batch` method. Closes #266.
theochap
pushed a commit
that referenced
this pull request
Jan 21, 2026
### Description Removes the `TryFrom` span batch for `RawSpanBatch`, inlining the coercion into a `to_raw_span_batch` method. Closes #266.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes infinite error loop on syncing an empty block by waiting for the block X blocks after it to exist.
Contributing Agreement