Skip to content

Fixing Block Subscription Re-orgs#265

Merged
willmeister merged 2 commits intomasterfrom
fixBlockSyncingReorgs
Sep 18, 2020
Merged

Fixing Block Subscription Re-orgs#265
willmeister merged 2 commits intomasterfrom
fixBlockSyncingReorgs

Conversation

@willmeister
Copy link

Description

Making it so that after the first tx in a block is final, we check to make sure it is in the same block and if not re-fetch the block by number to handle re-orgs.

Metadata

Fixes

  • Fixes # [Link to Issue]

Contributing Agreement

… make sure it is in the same block and if not re-fetch the block by number to handle re-orgs
Copy link
Contributor

@K-Ho K-Ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Very clean fix.

@@ -113,10 +113,16 @@ export class EthereumBlockProcessor {
)
// TODO: What happens on re-org? I think we're stuck waiting on this confirmation that will never come forever.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like this PR removes this TODO :)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha, good call!

@willmeister willmeister merged commit ed1f4fe into master Sep 18, 2020
@willmeister willmeister deleted the fixBlockSyncingReorgs branch September 18, 2020 20:23
snario pushed a commit that referenced this pull request Apr 14, 2021
* fix: licenses and constructor modifiers

* fix: apply review suggestions

* fix: update function modifiers and remove unused vars

* fix indentation

* fix indentation

* fix: remove unused params

* Revert "fix: remove unused params"

This reverts commit a321e9d39319432fb89bd77c1fc3ff2e1a08295d.

Co-authored-by: Maurelian <maurelian@protonmail.ch>
protolambda pushed a commit to protolambda/optimism that referenced this pull request May 1, 2022
bap2pecs pushed a commit to babylonlabs-io/optimism that referenced this pull request Jul 31, 2024
theochap pushed a commit that referenced this pull request Dec 10, 2025
Zena-park pushed a commit to tokamak-network/optimism that referenced this pull request Dec 30, 2025
…ward) ethereum-optimism#265

We advise these data entries to be reset prior to the external call, ensuring compliance with the CEI pattern and preventing re-entrancy attacks from manifesting.
theochap pushed a commit that referenced this pull request Jan 15, 2026
### Description

Re-introduces the `BatchReader` into `op-alloy-protocol`.

Batch compression already introduces the `brotli` and `miniz-oxzide`
deps.

The compression and decompression abstractions used here should be
improved for both directions: compression + decompression.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants