Skip to content

provider: add in gorli support#260

Merged
karlfloersch merged 6 commits intomasterfrom
provider-network
Sep 17, 2020
Merged

provider: add in gorli support#260
karlfloersch merged 6 commits intomasterfrom
provider-network

Conversation

@tynes
Copy link
Contributor

@tynes tynes commented Sep 16, 2020

Description

This adds in the url for the public ropsten node so that the provider can be instantiated like:

const provider = new OptimismProvider('gorli')

This would set the hostname as rinkeby.optimism.io.

Also notes this in the README.md

Questions

  • What is the actual url that is going to be used?

Metadata

Contributing Agreement

@tynes tynes changed the title Provider network provider: add in rinkeby support Sep 16, 2020
@tynes
Copy link
Contributor Author

tynes commented Sep 16, 2020

Noting the CI failure here:

microservices_1      | 2020-09-16T20:29:41.364Z error:service-entrypoint L1 node returned block number undefined when 0 was expected. Aborting deploy!
microservices_1      | (node:64) UnhandledPromiseRejectionWarning: Error: L1 node returned block number undefined when 0 was expected. Aborting deploy!
microservices_1      |     at deployContractsAndValidateDeployment (/server/packages/rollup-services/build/src/exec/services.js:228:15)
microservices_1      |     at processTicksAndRejections (internal/process/task_queues.js:86:5)
microservices_1      | (node:64) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). (rejection id: 30)
microservices_1      | (node:64) [DEP0018] DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.

edit: The CI appears to have failed here due to a timeout.

@tynes
Copy link
Contributor Author

tynes commented Sep 16, 2020

Updated to use gorli

@tynes tynes changed the title provider: add in rinkeby support provider: add in gorli support Sep 16, 2020
Copy link
Contributor

@karlfloersch karlfloersch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think probably best to change it back to Goerli but then after that I think this is good to go! Merrrrge!

@karlfloersch karlfloersch merged commit 160c143 into master Sep 17, 2020
@gakonst gakonst deleted the provider-network branch March 18, 2021 15:09
snario pushed a commit that referenced this pull request Apr 14, 2021
* add reset

* add to constructor
protolambda added a commit to protolambda/optimism that referenced this pull request May 1, 2022
…_source_cleanup

ref impl: Flatten sources & Cleanup Sync Start
Zena-park pushed a commit to tokamak-network/optimism that referenced this pull request Dec 30, 2025
theochap pushed a commit that referenced this pull request Jan 15, 2026
### Description

Since #259 adds `Batch` encoding, book examples can decode and encode
directly to and from the `Batch` types instead of the `SingleBatch`
type.
emhane added a commit that referenced this pull request Feb 3, 2026
Ref op-rs/op-reth#205

Removes redundant dep `reth-db-api` from `reth-optimism-trie`, since
used types are re-exported via `reth-db`

---------

Co-authored-by: Arun Dhyani <dhyaniarun7@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants