Fix Irrecoverable State for Queued to Sent Batch Failure Condition by willmeister · Pull Request #251 · ethereum-optimism/optimism

willmeister · 2020-09-03T21:07:08Z

Description

Shortens window during which a process restart would require manual intervention to fix rollup batches.

Questions

Is there an easy way to get the tx hash ahead of sending so that we can eliminate this race condition? Note: my main problem is with estimating and setting gasLimit and gasPrice -- I know it's doable by doing a lot more of what ethers wraps manually, but this seems like the right ratio of improvement : time.
Does it make sense to just add wallet nonce to the batch submission table and update that ahead of sending a batch? That way, we can always check to see that the pending tx count is as expected. But if a nonce is stored, can't find the tx associated with it so 🤷

Metadata

Fixes

Fixes # YAS-647

Contributing Agreement

I have read and understood the Optimism Contributing Guide and Code of Conduct and am following those guidelines in this pull request.

karlfloersch · 2020-09-03T21:46:42Z

Is there an easy way to get the tx hash ahead of sending so that we can eliminate this race condition?

~~You should be able to get the tx hash by hashing the output of: ethers-io/ethers.js#535 (comment)~~

EDIT: You figured this out and my suggestion wasn't quite right! 😄

Does it make sense to just add wallet nonce to the batch submission table and update that ahead of sending a batch?

Ah yes I think this does actually make sense. Especially it makes sense because it will make it way easier to 'bump up the gas price' for txs that are taking a really long time to be included. You can just see 'ok how many of my txs have gone through... which one is taking a while? how long ago did i submit it? oh it's been too long let me increase the gas price".

I know that DYDX's relayer has this logic for instance. I'm sure other relayers too but that's the one that I've used and seen in action

tynes · 2020-09-04T00:44:14Z

BatchSubmissionStatus.QUEUED is when its in the mempool and BatchSubmissionStatus.SUBMITTING is when its being sent to the mempool but before its confirmed to enter?

…by rolling own tx population and submission

willmeister · 2020-09-04T21:36:10Z

BatchSubmissionStatus.QUEUED is when its in the mempool and BatchSubmissionStatus.SUBMITTING is when its being sent to the mempool but before its confirmed to enter?

BatchSubmissionStatus.QUEUED it is guaranteed to have never been submitted to L1
BatchSubmissionStatus.SUBMITTING we are trying to submit it, but if our process fails here, it may or may not have been submitted
BatchSubmissionStatus.SENT sent and got at least 1 confirm on chain
BatchSubmissionStatus.FINALIZED There were at least < configurable finality blocks > confirms

karlfloersch

Alright great! Seems it wasn't too verbose to calculate the tx hash up front & so that's good. And with the submission logic everything seems right to me!

LGTM!

karlfloersch · 2020-09-05T02:16:04Z

packages/rollup-core/src/app/data/consumers/canonical-chain-batch-submitter.ts

+
+  protected async getBatchSubmissionBlockNumber(): Promise<number> {
+    // TODO: This will eventually be part of the output metadata from L2 tx outputs
+    //  Need to update geth to have this functionality so this is a mock for now


👍 ah yes we definitely need this. Got to double check that we have it represented as a ticket

karlfloersch · 2020-09-05T02:17:59Z

packages/rollup-core/src/app/data/consumers/state-commitment-chain-batch-submitter.ts

        stateRootBatch.startIndex
      )
+
+      txHash = keccak256(signedTx)


…UBMITTING status was not prefixed with 0x

* [Fix] CI on merge * rename

Closes celo-org/celo-blockchain-planning#629

Closes https://github.com/celo-org/celo-blockchain-planning/issues/629

Closes celo-org/celo-blockchain-planning#629

Closes https://github.com/celo-org/celo-blockchain-planning/issues/629

## Overview Adds a function in the `BootInfo` module that pulls in the rollup config based on the passed L2 chain ID.

Fixes #237 Adds more concrete error variants for `OpProofsStorageError` Co-authored-by: Arun Dhyani <dhyaniarun7@gmail.com>

Shortening race condition window for Queued to Sent issue

3097f68

willmeister added 2 commits September 4, 2020 14:42

Changing logic to completely prevent irrecoverable failure condition …

16dd1a2

…by rolling own tx population and submission

Fixing tests and small code bugs

5a099df

willmeister changed the title ~~Shortening Race Condition window for Queued to Sent Batch Failure Condition~~ Fix Irrecoverable State for Queued to Sent Batch Failure Condition Sep 4, 2020

karlfloersch approved these changes Sep 5, 2020

View reviewed changes

fixing tx estimation issue and issue where stored hash for batch in S…

3237e29

…UBMITTING status was not prefixed with 0x

willmeister merged commit 3c00289 into master Sep 8, 2020

willmeister deleted the YAS-647/FixBatchSubmissionQueuedToSentFailureCondition branch September 8, 2020 15:09

snario pushed a commit that referenced this pull request Apr 14, 2021

[Fix] CI on merge (#251)

ae19d70

* [Fix] CI on merge * rename

shenkeyao referenced this pull request in EspressoSystems/optimism-espresso-integration Mar 1, 2025

sequencer: Use higher sequencer drift for Celo (#251)

72672ea

Closes celo-org/celo-blockchain-planning#629

QuentinI referenced this pull request in EspressoSystems/optimism-espresso-integration Mar 7, 2025

sequencer: Use higher sequencer drift for Celo (#251)

d7d8354

Closes https://github.com/celo-org/celo-blockchain-planning/issues/629

QuentinI referenced this pull request in EspressoSystems/optimism-espresso-integration May 27, 2025

sequencer: Use higher sequencer drift for Celo (#251)

2c23f93

Closes celo-org/celo-blockchain-planning#629

dailinsubjam referenced this pull request in EspressoSystems/optimism-espresso-integration Oct 4, 2025

sequencer: Use higher sequencer drift for Celo (#251)

c14a156

Closes https://github.com/celo-org/celo-blockchain-planning/issues/629

theochap pushed a commit that referenced this pull request Dec 10, 2025

feat(client): Add RollupConfig to BootInfo (#251)

20ffe60

## Overview Adds a function in the `BootInfo` module that pulls in the rollup config based on the passed L2 chain ID.

emhane pushed a commit that referenced this pull request Feb 3, 2026

feat: Concrete error variants for reth-optimism-trie (#251)

c183e4e

Fixes #237 Adds more concrete error variants for `OpProofsStorageError` Co-authored-by: Arun Dhyani <dhyaniarun7@gmail.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix Irrecoverable State for Queued to Sent Batch Failure Condition#251

Fix Irrecoverable State for Queued to Sent Batch Failure Condition#251
willmeister merged 4 commits intomasterfrom
YAS-647/FixBatchSubmissionQueuedToSentFailureCondition

willmeister commented Sep 3, 2020

Uh oh!

karlfloersch commented Sep 3, 2020 •

edited

Loading

Uh oh!

tynes commented Sep 4, 2020

Uh oh!

willmeister commented Sep 4, 2020 •

edited

Loading

Uh oh!

karlfloersch left a comment

Uh oh!

karlfloersch Sep 5, 2020

Uh oh!

karlfloersch Sep 5, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

willmeister commented Sep 3, 2020

Description

Questions

Metadata

Fixes

Contributing Agreement

Uh oh!

karlfloersch commented Sep 3, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tynes commented Sep 4, 2020

Uh oh!

willmeister commented Sep 4, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

karlfloersch left a comment

Choose a reason for hiding this comment

Uh oh!

karlfloersch Sep 5, 2020

Choose a reason for hiding this comment

Uh oh!

karlfloersch Sep 5, 2020

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

karlfloersch commented Sep 3, 2020 •

edited

Loading

willmeister commented Sep 4, 2020 •

edited

Loading