-
Notifications
You must be signed in to change notification settings - Fork 4k
l2geth: Sync from Backend Queue #2296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 9 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
3e016ae
l2geth: Publish transactions to external msg queue
Inphi 935782f
recover from pub errors
Inphi f876add
synchronize Publish with ResumePublish
Inphi 36991e6
lint
Inphi a11c4c4
Merge branch 'develop' into feat/publish-tx
Inphi 9f05c87
add txpublisher.enable flag
Inphi 783252e
Introduce new Backend Queue
Inphi fe47425
log errors in sub cb
Inphi 3e7b5ab
add BackendQueue tests
Inphi 6810613
fix flags
Inphi de1ea95
nits
Inphi 8e64fd9
assert Tx Meta equals in test
Inphi f834886
Fix build; add changeset
Inphi f061820
Merge branch 'develop' into feat/publish-tx
Inphi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -32,6 +32,17 @@ func (q QueueOrigin) String() string { | |
| } | ||
| } | ||
|
|
||
| func (q QueueOrigin) MarshalJSON() ([]byte, error) { | ||
| switch q { | ||
| case QueueOriginSequencer: | ||
| return []byte("\"sequencer\""), nil | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Could you get rid of the need to the escapes by using a backtick string?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. certainly. thanks for pointing that out. |
||
| case QueueOriginL1ToL2: | ||
| return []byte("\"l1\""), nil | ||
| default: | ||
| return []byte("\"\""), nil | ||
| } | ||
| } | ||
|
|
||
| func (q *QueueOrigin) UnmarshalJSON(b []byte) error { | ||
| switch string(b) { | ||
| case "\"sequencer\"": | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.