Skip to content

Add mocked message passing contracts#229

Merged
karlfloersch merged 3 commits intomasterfrom
YAS-615/contracts/mock-messaging
Aug 27, 2020
Merged

Add mocked message passing contracts#229
karlfloersch merged 3 commits intomasterfrom
YAS-615/contracts/mock-messaging

Conversation

@smartcontracts
Copy link
Contributor

Description

Adds a few new contracts and corresponding tests, namely:

  • CrossDomainMessageReceiver.interface.sol
  • CrossDomainMessenger.interface.sol
  • MockCrossDomainMessageReceiver.sol
  • MockCrossDomainMessenger.sol

Mock contracts implement simulated message passing functionality for the sake of being able to test these things before the actual contracts are ready.

Questions

  • Does the API look ok? Want to make sure this is as accurate as possible.

Metadata

Fixes

Contributing Agreement

Copy link
Contributor

@K-Ho K-Ho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hype!! LGTM. Just to clarify, the reason why we need to be able to sendMessage from one messenger to another is that we want all L1 messages to be relayed by the same L2 messenger and all L2 messages to be relayed by the same L1 messenger?

)
internal
{
// Implement me!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this do anything?

Comment on lines +32 to +33
"build:copy": "yarn run build:copy:contracts",
"build:copy:contracts": "copyfiles -u 2 \"contracts/optimistic-ethereum/**/*.sol\" \"build/contracts\"",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this needed for?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's useful for being able to import the contracts into other packages

Copy link
Contributor

@karlfloersch karlfloersch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥

@karlfloersch karlfloersch merged commit a3fbb0b into master Aug 27, 2020
@K-Ho K-Ho deleted the YAS-615/contracts/mock-messaging branch September 1, 2020 20:31
snario pushed a commit that referenced this pull request Apr 14, 2021
* script: serve state dump

* feat: python2

* cleanup

* yarn: add serve script
OptimismBot pushed a commit that referenced this pull request Jan 31, 2025
Zena-park added a commit to tokamak-network/optimism that referenced this pull request Dec 30, 2025
Zena-park added a commit to tokamak-network/optimism that referenced this pull request Dec 30, 2025
theochap pushed a commit that referenced this pull request Jan 15, 2026
### Description

Adds `op-alloy-rpc-types-engine` docs to the book.
emhane pushed a commit that referenced this pull request Feb 3, 2026
This PR separates storage and account cursors which makes sense because
these two cursors may have very different seek/next implementations. In
the case of in-memory, a single cursor impl can still handle both, but
for MDBX, it makes sense to implement separate cursors.

Closes #236

---------

Co-authored-by: Arun Dhyani <dhyaniarun7@gmail.com>
emhane pushed a commit that referenced this pull request Feb 3, 2026
Based on #229

Adds tests to ensure that storing TrieUpdates that include deletions
actually deletes the nodes at that block height, and that updates take
precedence over deletions (same as `write_trie_updates` in Reth).

Closes #238
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants