YAS 430 OVM gasLimit-proportional burn for rate limiting #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3ecebe8.
willmeister
approved these changes
Aug 17, 2020
| return keccak256(abi.encodePacked( | ||
| _batchHeader.timestamp, | ||
| _batchHeader.isL1ToL2Tx, | ||
| _batchHeader.isL1ToL2Tx, // TODO REPLACE WITH QUEUE ORIGIN (if you are a PR reviewer please lmk!) |
| // TODO: figure out how we're going to authenticate this | ||
| return true; | ||
| // return _sender != tx.origin; | ||
| require(msg.sender == address(resolveCanonicalTransactionChain()), "Only the canonical transaction chain can dequeue L1->L2 queue transactions."); |
ben-chain
changed the base branch from
feat/YAS422/enforce-SM-gas-determinism
to
master
Collaborator
Author
|
For future reference, discussion on the |
qbzzt
added a commit
that referenced
this pull request
Apr 12, 2023
shenkeyao
referenced
this pull request
in EspressoSystems/optimism-espresso-integration
Mar 1, 2025
* migration: Add tests for state migration * migration: Fix issues shown by tests * migration: pass allowlist into state migration Allows for easier testing * migration: Add test with allowlist * Correct overwrite counter * Use in memory DB
QuentinI
referenced
this pull request
in EspressoSystems/optimism-espresso-integration
Mar 7, 2025
* migration: Add tests for state migration * migration: Fix issues shown by tests * migration: pass allowlist into state migration Allows for easier testing * migration: Add test with allowlist * Correct overwrite counter * Use in memory DB
agusduha
pushed a commit
that referenced
this pull request
Mar 20, 2025
* feat: make L1ERC721Bridge configurable in L1Block * feat: remove initializable from ERC721Bridge & L2ERC721Bridge * chore: update L2Genesis script * feat: update L1ERC721Bridge to make it initializable * chore: update Setup * chore: pre-pr ready * test: move common assertions out of conditional
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
* fix: pipeline builder * feat: pipeline builder * fix: use online provider impls * fix: feature flag builder example
Zena-park
added a commit
to tokamak-network/optimism
that referenced
this pull request
Dec 30, 2025
theochap
pushed a commit
that referenced
this pull request
Jan 15, 2026
related issues paradigmxyz/reth#12275 <!-- Thank you for your Pull Request. Please provide a description above and review the requirements below. Bug fixes and new features should include tests. Contributors guide: https://github.com/alloy-rs/core/blob/main/CONTRIBUTING.md The contributors guide includes instructions for running rustfmt and building the documentation. --> <!-- ** Please select "Allow edits from maintainers" in the PR Options ** --> ## Motivation <!-- Explain the context and why you're making that change. What is the problem you're trying to solve? In some cases there is not a problem and this can be thought of as being the motivation for your change. --> ## Solution <!-- Summarize the solution and provide any necessary context needed to understand the code change. --> ## PR Checklist - [ ] Added Tests - [ ] Added Documentation - [ ] Breaking changes --------- Co-authored-by: Matthias Seitz <[email protected]>
emhane
pushed a commit
that referenced
this pull request
Feb 3, 2026
Closes #217 Also fixed a bug where the `set_earliest_block_number_hash` was using `append` instead of `upsert`. --------- Co-authored-by: Arun Dhyani <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR covers YAS 430, which adds a gas rate limiter to the Safety and L1->L2 queues. It accomplishes this by requiring that you burn a proportional amount of gas on L1 based on the transaction's OVM gasLimit.
NOTE: This PR builds off #212 , so I have made the PR against that branch--diff will be much more readable this way as merging #212 is currently blocked.
Questions
Metadata
Fixes
Contributing Agreement