Merged
Conversation
ben-chain
approved these changes
Aug 4, 2020
Collaborator
ben-chain
left a comment
There was a problem hiding this comment.
Woohoo!! LGTM, not much feedback--proof is in the successful deployment pudding :)
| returns (bool) | ||
| { | ||
| return _sender == l1ToL2TransactionPasser; | ||
| // TODO: figure out how we're going to authenticate this |
Collaborator
There was a problem hiding this comment.
👍 should be handled by gas metering soon
Co-authored-by: ben-chain <ben@pseudonym.party>
Lredhdx
pushed a commit
to node-real/combo-optimism
that referenced
this pull request
Jun 17, 2024
bap2pecs
pushed a commit
to babylonlabs-io/optimism
that referenced
this pull request
Jul 31, 2024
agusduha
pushed a commit
that referenced
this pull request
Mar 20, 2025
* feat: make L1Block source of truth for OptimismMintableERC721Factory * feat: update L2Genesis script * test: update L1Block tests and setup * chore: semgrep & pre-pr ready * chore: update semver OptimismMintableERC721Factory * Merge sc-feat/standard-l2-genesis into feat/standard-erc721-factory * docs: update natspec for OptimismMintableERC721Factory::version * chore: remove unnecessary casting * docs: update natspec for REMOTE_CHAIN_ID * chore: pre-pr ready
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
Simplifies `TrieDB` by assuming it will be wrapped with [`revm::State`](https://github.com/bluealloy/revm/blob/fadf6fbe43a3022c1406c0d8ee062a83e951d4d3/crates/revm/src/db/states/state.rs#L29). The `State` struct in `revm` is better for our usecase, since it allows for merging a `BundleState` after a full block's execution. The previous implementation had the fatal flaw having to recompute the state root every time the `DatabaseCommit` trait implementation was invoked, which was not suitable. Examples of usage may be found within the rustdoc for `TrieDB`.
theochap
pushed a commit
that referenced
this pull request
Jan 15, 2026
### Description Ports span batch validity checks to `op-alloy-protocol`. ### Provenance Part of a port migrating the batch types from `kona-derive` to `op-alloy`. See [`kona#695`](op-rs/kona#695).
emhane
added a commit
that referenced
this pull request
Feb 3, 2026
Based on op-rs/op-reth#197 This PR implements the live state collector on top of the `OpProofsStateProvider` created in the previous PR. This sync process tries to re-execute all blocks from the current block of the external database to tip. --------- Co-authored-by: Emilia Hane <elsaemiliaevahane@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a contract deployment yarn task with documentation on configuration and how to use it.
Metadata
Fixes
Contributing Agreement