op-acceptance: migrate interop tests to supernode, skip on op-reth#19754
Merged
op-acceptance: migrate interop tests to supernode, skip on op-reth#19754
Conversation
Migrate interop acceptance tests from supervisor-based presets (NewSimpleInterop) to supernode-based presets (NewTwoL2SupernodeInterop) where the change is mechanical (preset swap + field renames). Tests migrated to supernode preset: - TestReorgInvalidExecMsgs (reorgs/ — also replaced Supervisor.SafeBlockID convergence check with Supernode.AwaitValidatedTimestamp) - TestInteropHappyTx (message/) - TestInteropMon (message/) - TestL2CLResync (sync/simple_interop/) Tests converted from unconditional skip to SkipOnOpReth: - TestRelayWithInvalidMessagesSteady (loadtest/) - TestReorgInitExecMsg (reorgs/) - TestReorgInvalidExecMsgs (reorgs/) TestInteropFaultProofs_InvalidBlock remains fully skipped — broken on all EL backends due to supernode proof expectation mismatches. Other changes: - Fix SkipOnOpReth helper to skip when EL kind is anything other than op-geth (not just when it equals op-reth) - Fix AssertTxInBlock doc comment - Normalize TODO comment format to use #19411 short form
wwared
commented
Mar 25, 2026
op-acceptance-tests/tests/interop/proofs/serial/interop_fault_proofs_test.go
Show resolved
Hide resolved
karlfloersch
approved these changes
Mar 25, 2026
Contributor
There was a problem hiding this comment.
Seems good to me! One small nit
Also - I don't really understand https://github.com/ethereum-optimism/optimism/pull/19754/changes#r2990460312 so if there's something related to kona proofs that should be blocking this pr then please don't take my approval as gospel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NewSimpleInterop) to supernode-based presets (NewTwoL2SupernodeInterop) where the change is mechanicalt.Skip()calls toSkipOnOpReth()for tests that only fail on op-reth (feat(op-reth): implement interop tx pool filter and reorg eviction #19411)SkipOnOpRethhelper to skip when EL kind is anything other than op-geth (not just when it equals op-reth)Tests migrated to supernode preset
TestReorgInvalidExecMsgs— also replacedSupervisor.SafeBlockIDconvergence check withSupernode.AwaitValidatedTimestampTestInteropHappyTxTestInteropMonTestL2CLResyncTests converted from unconditional skip to SkipOnOpReth
TestRelayWithInvalidMessagesSteadyTestReorgInitExecMsgTestReorgInvalidExecMsgsOther
TestInteropFaultProofs_InvalidBlockremains fully skipped — broken on all EL backends due to supernode proof expectation mismatchesAssertTxInBlockdoc comment#19411short formTest plan
DEVSTACK_L2EL_KIND=op-gethTestReorgInvalidExecMsgs(3 subtests) — PASS on supernode presetTestReorgInitExecMsg— PASSTestRelayWithInvalidMessagesSteady— PASSTestSupernodeInteropInvalidMessageReplacement— PASSTestSupernodeSameTimestampInvalidTransitive— PASSTestSupernodeSameTimestampCycle— PASSTestInteropFaultProofs_InvalidBlock— correctly SKIPsTestInteropHappyTx,TestInteropMon,TestL2CLResync— correctly SKIP (compile clean)