Add L1RollupTxId to RollupTransaction#196
Merged
willmeister merged 4 commits intomasterfrom Jul 31, 2020
Merged
Conversation
… to GethSubmission, simplifying the data structure
karlfloersch
approved these changes
Jul 30, 2020
Contributor
karlfloersch
left a comment
karlfloersch
left a comment
There was a problem hiding this comment.
Said it before & I'll say it again -- very grateful for the clear naming!
Left one tiny clarifying comment but this seemed to be a super straightforward PR!
| ], | ||
| rollupTransactions: res.map((row: Row, indexWithinSubmission: number) => { | ||
| const tx: RollupTransaction = { | ||
| l1RollupTxId: parseInt(row['id'], 10), |
Contributor
There was a problem hiding this comment.
Ah so adding the ID was basically trivial because we already had one assigned by the DB--that right?
Author
There was a problem hiding this comment.
Yep, it's just a matter of slapping the DB's primary key onto the data structure.
…ming for Geth Submissions
Lredhdx
pushed a commit
to node-real/combo-optimism
that referenced
this pull request
Jun 17, 2024
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
Zena-park
added a commit
to tokamak-network/optimism
that referenced
this pull request
Dec 30, 2025
Zena-park
added a commit
to tokamak-network/optimism
that referenced
this pull request
Dec 30, 2025
theochap
pushed a commit
that referenced
this pull request
Jan 15, 2026
### Description Ports the batch transactions to `op-alloy-protocol`. ### Provenance Part of a port migrating the batch types from `kona-derive` to `op-alloy`. See [`kona#695`](op-rs/kona#695).
emhane
added a commit
that referenced
this pull request
Feb 2, 2026
Based on op-rs/op-reth#183 This PR adds a backfill job that accepts a DB transaction and copies the current state to the database. The transaction ensures we see a consistent view of the database at the current block, even if the node is syncing. This requires `--db.read-transaction-timeout 0`. This currently doesn't handle interrupting the job because the state may update while syncing and may read a different version of the database upon restart. --------- Co-authored-by: Arun Dhyani <dhyaniarun7@gmail.com> Co-authored-by: Emilia Hane <elsaemiliaevahane@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds L1RollupTxId to RollupTransactions so it can be passed in submissions to geth.
Also renames BlockBatches and decreases their size from all of the batches that were in one L1 block to a single batch from a single event log from an L1 block.
Metadata
Fixes
Contributing Agreement