fix: correct cd paths in kona action test recipes#19597
Merged
Conversation
1 task
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #19597 +/- ##
===========================================
Coverage 75.3% 75.3%
===========================================
Files 680 485 -195
Lines 71998 60696 -11302
===========================================
- Hits 54254 45741 -8513
+ Misses 17600 14955 -2645
+ Partials 144 0 -144
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
ajsutton
force-pushed
the
aj/fix/kona-proof-action-cd-path
branch
from
dcd5d02 to
b62b93d
Compare
SOURCE is rust/kona/tests (3 levels deep), so reaching op-e2e/ at the repo root requires ../../../ not ../../. The broken paths caused cd to fail silently (no set -e), then gotestsum ran in the wrong directory finding no Go files. The `exit 0` in the parallel branch masked the failure, making CI report success despite no tests actually running. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The action-tests-single-run and action-tests-interop-run recipes had no set -e, so a failed cd (or any other command) would silently continue. Combined with `exit 0` in the parallel branch, this masked failures entirely — CI reported success with zero tests running. - Add `set -euo pipefail` to both recipes so any failure aborts - Replace `exit 0` with `exit` so xargs/gotestsum's exit code propagates Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
ajsutton
force-pushed
the
aj/fix/kona-proof-action-cd-path
branch
from
b62b93d to
ff8d8bc
Compare
theochap
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes broken
cdpaths inrust/kona/tests/justfilefor theaction-tests-single-runandaction-tests-interop-runrecipes.SOURCEissource_directory()which resolves torust/kona/tests(3 levels deep from repo root). The paths used../../op-e2e/actions/...(2 levels) instead of../../../op-e2e/actions/...(3 levels), so thecdfailed. Since the scripts don't useset -e, execution continued in the wrong directory — gotestsum found no Go files and reportedFAIL . [setup failed]. Theexit 0in the CircleCI parallel branch then masked the failure entirely.Impact:
kona-proof-action-singleCI job has been reporting success despite running zero tests.Test plan
kona-proof-action-singleCI job actually runs tests after this fixaction-tests-interop-runpath is also correct🤖 Generated with Claude Code