fix(ci): add rust/op-reth/tests/ to .semgrepignore#19522
Merged
Conversation
…acts Fixes semgrep-scan-local CI failure on develop caused by sol-style-input-arg-fmt rule violations in SimpleStorage.sol and TokenVault.sol test contracts. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
The compute-git-versions target was moved to a deprecated shim that delegates to just, but the GitHub Actions prep job doesn't have just installed. Restore it as a native make target that calls the shell script directly. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This reverts commit 69dd757.
The path was moved from rust/op-reth/crates/tests/ (already ignored) to rust/op-reth/tests/ in #19252, taking test contracts out of the ignore scope and breaking semgrep-scan-local on develop. Revert the Solidity file changes and ignore the new path instead — these are test contracts, not production code. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ajsutton
changed the title
theochap
approved these changes
Mar 13, 2026
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
semgrep-scan-localCI failure ondevelopethereum-optimism/optimism#19252moved test contracts fromrust/op-reth/crates/tests/(already in.semgrepignore) torust/op-reth/tests/(not ignored), causing 3sol-style-input-arg-fmtviolations to surfacerust/op-reth/tests/to.semgrepignore— these are test contracts foreth_getProoftesting, not production Solidity code, consistent with the existing exclusion for the old pathTest plan
semgrep-scan-localCI job passes on this branch🤖 Generated with Claude Code