experiment: use op-reth for all interop acceptance tests#19416
Closed
experiment: use op-reth for all interop acceptance tests#19416
Conversation
Add WithL2ELKind option and make WithL2ELNode lazy so the EL client kind can be set via BeforeDeploy. Expose WithRethL2EL preset and apply it to all 16 interop test suites. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #19416 +/- ##
==========================================
+ Coverage 75.5% 80.2% +4.6%
==========================================
Files 193 138 -55
Lines 11250 7220 -4030
==========================================
- Hits 8503 5793 -2710
+ Misses 2601 1427 -1174
+ Partials 146 0 -146
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Contributor
Author
|
Closing in favour of #19408 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Experiment to run all interop acceptance tests against op-reth instead of op-geth.
Infrastructure changes
op-devstack/sysgo/orchestrator.go: Addl2ELKind stringfield toOrchestratorop-devstack/sysgo/l2_el.go: AddWithL2ELKind(kind string)option; makeWithL2ELNodelazy (defers geth/reth decision toAfterDeployso it can be overridden viaBeforeDeployhooks)op-devstack/presets/interop.go: AddWithRethL2EL()common preset optionTest changes
Add
presets.WithRethL2EL()to all 16init_test.gofiles underop-acceptance-tests/tests/interop/.Backwards compatibility
The existing
DEVSTACK_L2EL_KINDenv var continues to work. The orchestrator field takes precedence when set, otherwise falls back to the env var, then defaults to op-geth.Prerequisites
OP_RETH_EXEC_PATHmust point to a valid op-reth binary.🤖 Generated with Claude Code