supernode: Add 30s Context Deadline to Inner Node Shutdown#19213
Merged
axelKingsley merged 1 commit intodevelopfrom Feb 17, 2026
Merged
supernode: Add 30s Context Deadline to Inner Node Shutdown#19213axelKingsley merged 1 commit intodevelopfrom
axelKingsley merged 1 commit intodevelopfrom
Conversation
scharissis
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I suspect Supernode is partially responsible for the recent 2h test timeouts.
My current understanding is that a difference in CI test runner behavior is now exposing a failure to shutdown some applications. Proofs found one application which failed to notice closed context while waiting on a channel.
However, I also saw one instance of Supernode doing this, and from the appearance of the logs, the inner node was stuck running.
When the inner node is stopped, no deadline is used, and that's my current best explanation for what I saw.
In any case, seems like a good improvement to attach timeouts to closing signals so we aren't stuck waiting at close forever, and the test can actually end.