op-challenger: Fix race in shutdown which caused it to hang.#19203
Merged
op-challenger: Fix race in shutdown which caused it to hang.#19203
Conversation
Inphi
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a race condition in op-challenger's scheduler workers where the result reader may exit before the workers and the workers then block forever on publishing the result to the out channel. Since we're shutting down anyway the result can just be discarded if the context is cancelled.
This was causing the 2h timeouts in CI.
Tests
Added unit test that previously blocked and now exits cleanly.