ci: Fix make reproducible-prestate.#19184
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## develop #19184 +/- ##
==========================================
- Coverage 75.9% 69.3% -6.7%
==========================================
Files 190 190
Lines 10966 10966
==========================================
- Hits 8334 7607 -727
- Misses 2488 3215 +727
Partials 144 144
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
c60382c to
da34be6
Compare
Inphi
left a comment
There was a problem hiding this comment.
Looks good. I think this looks good, gotta be careful that -j doesn't introduce non-determinism if the kona docker build copies some build artifacts from the op-program prestate build. Though I don't think that's the case here.
|
Yeah they're quite separate. We'd see failures if they did have dependencies as it would create a race condition. Definitely something to be careful with though. |
* ci: Fix make reproducible-prestate. Adjust reproducible-prestate so the op-program and kona prestates can be built in parallel. Depend on the full prestate build in CI to ensure it always works. * Use machine executor. * Remove remote docker setup. * Remove separate cannon-kona build job. * Build cannon and op-program binaries. * Depend on go-binaries-for-sysgo in e2e tests
Adjust reproducible-prestate so the op-program and kona prestates can be built in parallel. Depend on the full prestate build in CI to ensure it always works.
1867cb6 to
7e1d11c
Compare
Description
Adjust reproducible-prestate so the op-program and kona prestates can be built in parallel. Depend on the full prestate build in CI to ensure it always works.
Also changed the top level
reproducible-prestatetarget so that the prestates can be built in parallel (when usingmake -j).