Skip to content

ci: Fix make reproducible-prestate.#19184

Merged
ajsutton merged 6 commits intodevelopfrom
aj/fix-reproducible-prestate
Feb 17, 2026
Merged

ci: Fix make reproducible-prestate.#19184
ajsutton merged 6 commits intodevelopfrom
aj/fix-reproducible-prestate

Conversation

@ajsutton
Copy link
Contributor

@ajsutton ajsutton commented Feb 13, 2026

Description

Adjust reproducible-prestate so the op-program and kona prestates can be built in parallel. Depend on the full prestate build in CI to ensure it always works.

Also changed the top level reproducible-prestate target so that the prestates can be built in parallel (when using make -j).

@codecov
Copy link

codecov bot commented Feb 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.3%. Comparing base (42fc404) to head (7e1d11c).
⚠️ Report is 2 commits behind head on develop.

❗ There is a different number of reports uploaded between BASE (42fc404) and HEAD (7e1d11c). Click for more details.

HEAD has 6 uploads less than BASE
Flag BASE (42fc404) HEAD (7e1d11c)
contracts-bedrock-tests 12 6
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #19184     +/-   ##
==========================================
- Coverage     75.9%    69.3%   -6.7%     
==========================================
  Files          190      190             
  Lines        10966    10966             
==========================================
- Hits          8334     7607    -727     
- Misses        2488     3215    +727     
  Partials       144      144             
Flag Coverage Δ
cannon-go-tests-64 66.4% <ø> (ø)
contracts-bedrock-tests 71.0% <ø> (-10.5%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 33 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ajsutton ajsutton marked this pull request as ready for review February 13, 2026 04:13
@ajsutton ajsutton force-pushed the aj/fix-reproducible-prestate branch from c60382c to da34be6 Compare February 13, 2026 04:15
Copy link
Contributor

@Inphi Inphi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think this looks good, gotta be careful that -j doesn't introduce non-determinism if the kona docker build copies some build artifacts from the op-program prestate build. Though I don't think that's the case here.

@ajsutton ajsutton added this pull request to the merge queue Feb 16, 2026
@ajsutton
Copy link
Contributor Author

Yeah they're quite separate. We'd see failures if they did have dependencies as it would create a race condition. Definitely something to be careful with though.

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 16, 2026
@ajsutton ajsutton added this pull request to the merge queue Feb 16, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 16, 2026
@ajsutton ajsutton added this pull request to the merge queue Feb 16, 2026
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 16, 2026
@ajsutton ajsutton added this pull request to the merge queue Feb 17, 2026
github-merge-queue bot pushed a commit that referenced this pull request Feb 17, 2026
* ci: Fix make reproducible-prestate.

Adjust reproducible-prestate so the op-program and kona prestates can be built in parallel.
Depend on the full prestate build in CI to ensure it always works.

* Use machine executor.

* Remove remote docker setup.

* Remove separate cannon-kona build job.

* Build cannon and op-program binaries.

* Depend on go-binaries-for-sysgo in e2e tests
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Feb 17, 2026
Adjust reproducible-prestate so the op-program and kona prestates can be built in parallel.
Depend on the full prestate build in CI to ensure it always works.
@ajsutton ajsutton force-pushed the aj/fix-reproducible-prestate branch from 1867cb6 to 7e1d11c Compare February 17, 2026 19:56
@ajsutton ajsutton enabled auto-merge February 17, 2026 19:56
@ajsutton ajsutton added this pull request to the merge queue Feb 17, 2026
Merged via the queue into develop with commit 6af8caa Feb 17, 2026
79 checks passed
@ajsutton ajsutton deleted the aj/fix-reproducible-prestate branch February 17, 2026 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants