op-batcher: Record unsafe_da_bytes metric even when throttling disabled#19138
Merged
op-batcher: Record unsafe_da_bytes metric even when throttling disabled#19138
unsafe_da_bytes metric even when throttling disabled#19138Conversation
This means we can still track the metric when throttling is disabled.
if we can't send on the channel, we drop the update anyway
geoknee
changed the title
joshklop
reviewed
Feb 10, 2026
This commit adds a test case to verify the behavior of the batch submitter when throttling is disabled (LowerThreshold = 0). The test ensures that: - The throttling loop does not start - No throttle updates are sent to the endpoint - Unsafe data availability bytes metric is still recorded - The driver can process blocks and update metrics without running the throttling loop
Contributor
Plan expiredYour subscription has expired. Please renew your subscription to continue using CI/CD integration and other features. |
geoknee
changed the title
unsafe_da_bytes metric even when throttling disabled
joshklop
approved these changes
Feb 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This means we can still track the metric when throttling is disabled.
Adds to unit tests showing that metrics are always emitted even when throttling is not enabled.