Skip to content

op-supernode/virtual_node: Update L1 genesis handling for genesis L2 block#19114

Merged
raffaele-oplabs merged 2 commits intodevelopfrom
gk/supernode-safedb
Feb 10, 2026
Merged

op-supernode/virtual_node: Update L1 genesis handling for genesis L2 block#19114
raffaele-oplabs merged 2 commits intodevelopfrom
gk/supernode-safedb

Conversation

@geoknee
Copy link
Contributor

@geoknee geoknee commented Feb 9, 2026

Clarify that for the genesis L2 block, we always return L1 block 0 without relying on the original configuration's L1 genesis. This allows for more flexibility in dispute game scenarios involving earlier L1 blocks.

Brings into line with this code

if s.SafeHeadNotifs.Enabled() && x.CrossSafe.ID() == s.Config.Genesis.L2 {
// The rollup genesis block is always safe by definition. So if the pipeline resets this far back we know
// we will process all safe head updates and can record genesis as always safe from L1 genesis.
// Note that it is not safe to use cfg.Genesis.L1 here as it is the block immediately before the L2 genesis
// but the contracts may have been deployed earlier than that, allowing creating a dispute game
// with a L1 head prior to cfg.Genesis.L1

Clarify that for the genesis L2 block, we always return L1 block 0
without relying on the original configuration's L1 genesis. This allows
for more flexibility in dispute game scenarios involving earlier L1
blocks.
@geoknee geoknee requested a review from a team as a code owner February 9, 2026 16:18
@codecov
Copy link

codecov bot commented Feb 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 77.2%. Comparing base (db87881) to head (f0f562b).

Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #19114     +/-   ##
==========================================
+ Coverage     76.3%    77.2%   +0.9%     
==========================================
  Files          188      133     -55     
  Lines        10946     6916   -4030     
==========================================
- Hits          8360     5345   -3015     
+ Misses        2440     1571    -869     
+ Partials       146        0    -146     
Flag Coverage Δ
cannon-go-tests-64 ?
contracts-bedrock-tests 77.2% <ø> (-4.5%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 64 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@geoknee geoknee enabled auto-merge February 10, 2026 11:32
@geoknee geoknee disabled auto-merge February 10, 2026 13:44
@geoknee geoknee enabled auto-merge February 10, 2026 13:44
@raffaele-oplabs raffaele-oplabs removed their request for review February 10, 2026 13:46
@geoknee geoknee marked this pull request as draft February 10, 2026 13:56
auto-merge was automatically disabled February 10, 2026 13:56

Pull request was converted to draft

@geoknee geoknee marked this pull request as ready for review February 10, 2026 13:56
@geoknee geoknee enabled auto-merge February 10, 2026 13:56
@geoknee geoknee added the A-op-supernode Area: op-supernode label Feb 10, 2026
@raffaele-oplabs raffaele-oplabs added this pull request to the merge queue Feb 10, 2026
Merged via the queue into develop with commit be1eaaf Feb 10, 2026
78 checks passed
@raffaele-oplabs raffaele-oplabs deleted the gk/supernode-safedb branch February 10, 2026 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-op-supernode Area: op-supernode

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants