Skip to content

op-acceptance: Add test for next super root not being available.#19112

Merged
Inphi merged 2 commits intodevelopfrom
aj/unknown-next-superroot-test
Feb 10, 2026
Merged

op-acceptance: Add test for next super root not being available.#19112
Inphi merged 2 commits intodevelopfrom
aj/unknown-next-superroot-test

Conversation

@ajsutton
Copy link
Contributor

@ajsutton ajsutton commented Feb 9, 2026

Description

Add a test to ensure that the challenger calculates the correct transition when the next superroot is unknown but the first chain does have the next block available on L1. It should only transition to the invalid hash on the second chain block.

The FPP tests were moved to their own package so they can run in parallel with the other proofs tests since they're pretty long running but can't run in parallel on the same devnet.

Tests

Confirmed the test reproduces the original bug by re-introducing the issue into the challenger provider and confirming the FPP run detects the difference.

Metadata

fixes #18643

@ajsutton ajsutton requested a review from a team as a code owner February 9, 2026 02:07
@ajsutton ajsutton requested a review from maurelian February 9, 2026 02:07
@codecov
Copy link

codecov bot commented Feb 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.0%. Comparing base (a333785) to head (86a143c).

Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #19112     +/-   ##
==========================================
- Coverage     76.3%    76.0%   -0.4%     
==========================================
  Files          188      188             
  Lines        10946    10946             
==========================================
- Hits          8360     8327     -33     
- Misses        2440     2475     +35     
+ Partials       146      144      -2     
Flag Coverage Δ
cannon-go-tests-64 66.4% <ø> (-0.9%) ⬇️
contracts-bedrock-tests 81.6% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

…other challenger tests. Restart the sequencer after the test.
@ajsutton ajsutton force-pushed the aj/unknown-next-superroot-test branch from ce7aef0 to da0e647 Compare February 9, 2026 03:03
@Inphi Inphi enabled auto-merge February 10, 2026 17:09
@Inphi Inphi added this pull request to the merge queue Feb 10, 2026
Merged via the queue into develop with commit 36b7131 Feb 10, 2026
79 checks passed
@Inphi Inphi deleted the aj/unknown-next-superroot-test branch February 10, 2026 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

op-challenger: Review correct trace output when next super root is not found

2 participants