op-supernode: never rewind over finalized head#19109
Merged
Conversation
geoknee
changed the title
geoknee
changed the title
github-merge-queue bot
pushed a commit
that referenced
this pull request
Feb 6, 2026
* Update RewindFinalizedHeadBackward test to expect panic * Fix rewind test finalized block reference * Use error handling instead of panic
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #19066
Instead of a panic, this condition actually triggers a sentinel critical error. This means that the virtual node will effectively crash (or refuse to come back up), while the rest of the supernode can continue running.