Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #19073 +/- ##
==========================================
+ Coverage 76.3% 81.6% +5.2%
==========================================
Files 188 133 -55
Lines 10943 6913 -4030
==========================================
- Hits 8359 5646 -2713
+ Misses 2438 1267 -1171
+ Partials 146 0 -146
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
smartcontracts
force-pushed
the
fix/verify-opcm-security-gaps
branch
from
1dfaaad to
e58aa29
Compare
- Remove documented but unimplemented MIN:<value> check type - Remove unused _verifyMinValue function - Add missing env vars to test_verifyOpcmCorrectness_succeeds: - EXPECTED_L1_PAO_MULTISIG - EXPECTED_CHALLENGER - EXPECTED_WITHDRAWAL_DELAY_SECONDS Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
The _verifyZeroOnMainnet check should also be skipped in testing environments where we can't control the actual chain state. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
JosepBove
reviewed
Feb 5, 2026
JosepBove
reviewed
Feb 5, 2026
maurelian
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a number of gaps in VerifyOPCM where variables in OPCM deployments could theoretically be manipulated if the deployer address were entirely malicious.