Skip to content

fix: SuperchainConfig comments and test refactoring#19065

Merged
smartcontracts merged 3 commits intodevelopfrom
sc-feat/opcm2-fix-superchain-comments-v2
Feb 5, 2026
Merged

fix: SuperchainConfig comments and test refactoring#19065
smartcontracts merged 3 commits intodevelopfrom
sc-feat/opcm2-fix-superchain-comments-v2

Conversation

@smartcontracts
Copy link
Contributor

  • Remove outdated warning comment from SuperchainConfig
  • Bump SuperchainConfig version to 2.4.1
  • Fix comment in OPContractsManagerV2
  • Refactor test helpers: move NeedsSuperchainConfigUpgrade to testutil package
  • Update add-game-type-v2 tests to deploy a full OP chain

@smartcontracts smartcontracts requested review from a team as code owners February 3, 2026 18:11
@codecov
Copy link

codecov bot commented Feb 3, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.6%. Comparing base (f6f815c) to head (8982b2e).
⚠️ Report is 17 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #19065     +/-   ##
==========================================
+ Coverage     76.0%    81.6%   +5.6%     
==========================================
  Files          188      133     -55     
  Lines        10943     6913   -4030     
==========================================
- Hits          8326     5647   -2679     
+ Misses        2473     1266   -1207     
+ Partials       144        0    -144     
Flag Coverage Δ
cannon-go-tests-64 ?
contracts-bedrock-tests 81.6% <100.0%> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ages/contracts-bedrock/src/L1/SuperchainConfig.sol 100.0% <ø> (ø)
...racts-bedrock/src/L1/opcm/OPContractsManagerV2.sol 97.2% <100.0%> (ø)

... and 56 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

smartcontracts and others added 3 commits February 3, 2026 15:57
- Remove outdated warning comment from SuperchainConfig
- Bump SuperchainConfig version to 2.4.1
- Fix comment in OPContractsManagerV2
- Refactor test helpers: move NeedsSuperchainConfigUpgrade to testutil package
- Update add-game-type-v2 tests to deploy a full OP chain

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
@smartcontracts smartcontracts force-pushed the sc-feat/opcm2-fix-superchain-comments-v2 branch from b72568c to 8982b2e Compare February 3, 2026 22:17
@0xiamflux
Copy link
Contributor

LGTM

Copy link
Member

@JosepBove JosepBove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smartcontracts smartcontracts added this pull request to the merge queue Feb 5, 2026
Merged via the queue into develop with commit 6d0d308 Feb 5, 2026
211 checks passed
@smartcontracts smartcontracts deleted the sc-feat/opcm2-fix-superchain-comments-v2 branch February 5, 2026 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants