fix: SuperchainConfig comments and test refactoring#19065
Merged
smartcontracts merged 3 commits intodevelopfrom Feb 5, 2026
Merged
fix: SuperchainConfig comments and test refactoring#19065smartcontracts merged 3 commits intodevelopfrom
smartcontracts merged 3 commits intodevelopfrom
Conversation
Contributor
smartcontracts
commented
Feb 3, 2026
- Remove outdated warning comment from SuperchainConfig
- Bump SuperchainConfig version to 2.4.1
- Fix comment in OPContractsManagerV2
- Refactor test helpers: move NeedsSuperchainConfigUpgrade to testutil package
- Update add-game-type-v2 tests to deploy a full OP chain
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #19065 +/- ##
==========================================
+ Coverage 76.0% 81.6% +5.6%
==========================================
Files 188 133 -55
Lines 10943 6913 -4030
==========================================
- Hits 8326 5647 -2679
+ Misses 2473 1266 -1207
+ Partials 144 0 -144
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
- Remove outdated warning comment from SuperchainConfig - Bump SuperchainConfig version to 2.4.1 - Fix comment in OPContractsManagerV2 - Refactor test helpers: move NeedsSuperchainConfigUpgrade to testutil package - Update add-game-type-v2 tests to deploy a full OP chain Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
b72568c to
8982b2e
Compare
Contributor
|
LGTM |
maurelian
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.