Skip to content

maint: better comments for migration function #19006

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
smartcontracts merged 1 commit into from
Jan 30, 2026
Merged

maint: better comments for migration function #19006

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/contracts-bedrock/snapshots/semver-lock.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,8 @@
"sourceCodeHash": "0xb3184aa5d95a82109e7134d1f61941b30e25f655b9849a0e303d04bbce0cde0b"
},
"src/L1/opcm/OPContractsManagerV2.sol:OPContractsManagerV2": {
"initCodeHash": "0x6b2d8f2796b7f348410b2cf429c6e0c6884ef9b500f4ee8d0728a879ae5ed911",
"sourceCodeHash": "0x9d36fe176e2c201854f13d88be3a5d11a714de876c6d6585d367e4392fd9d091"
"initCodeHash": "0x5f3548d6d5502669d34ff3104826d8498c3f74be2f6840a6acb9860e266d96a8",
"sourceCodeHash": "0xf7c02dec35e9c34e7e3e8f1fe939f7b84243064b423e38ba82fb06e389732cc7"
},
"src/L2/BaseFeeVault.sol:BaseFeeVault": {
"initCodeHash": "0x838bbd7f381e84e21887f72bd1da605bfc4588b3c39aed96cbce67c09335b3ee",
Expand Down
5 changes: 5 additions & 0 deletions packages/contracts-bedrock/src/L1/opcm/OPContractsManagerMigrator.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,11 @@ contract OPContractsManagerMigrator is OPContractsManagerUtilsCaller {
/// @dev WARNING: This is a one-way operation. You cannot easily undo this operation without a
/// smart contract upgrade. Do not call this function unless you are 100% confident that
/// you know what you're doing and that you are prepared to fully execute this migration.
/// You SHOULD NOT CALL THIS FUNCTION IN PRODUCTION unless you are absolutely sure that
/// you know what you are doing.
/// @dev WARNING: Executing this function WILL result in all prior withdrawal proofs being
/// invalidated. Users will have to submit new proofs for their withdrawals in the
/// OptimismPortal contract. THIS IS EXPECTED BEHAVIOR.
/// @dev NOTE: Unlike other functions in OPCM, this is a one-off function used to serve the
/// temporary need to support the interop migration action. It will likely be removed in
/// the near future once interop support is baked more directly into OPCM. It does NOT
Expand Down
9 changes: 7 additions & 2 deletions packages/contracts-bedrock/src/L1/opcm/OPContractsManagerV2.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,9 +147,9 @@ contract OPContractsManagerV2 is ISemver, OPContractsManagerUtilsCaller {
/// - Major bump: New required sequential upgrade
/// - Minor bump: Replacement OPCM for same upgrade
/// - Patch bump: Development changes (expected for normal dev work)
/// @custom:semver 7.0.5
/// @custom:semver 7.0.6
function version() public pure returns (string memory) {
return "7.0.5";
return "7.0.6";
}

/// @param _standardValidator The standard validator for this OPCM release.
Expand Down Expand Up @@ -253,6 +253,11 @@ contract OPContractsManagerV2 is ISemver, OPContractsManagerUtilsCaller {
/// @dev WARNING: This is a one-way operation. You cannot easily undo this operation without a
/// smart contract upgrade. Do not call this function unless you are 100% confident that
/// you know what you're doing and that you are prepared to fully execute this migration.
/// You SHOULD NOT CALL THIS FUNCTION IN PRODUCTION unless you are absolutely sure that
/// you know what you are doing.
/// @dev WARNING: Executing this function WILL result in all prior withdrawal proofs being
/// invalidated. Users will have to submit new proofs for their withdrawals in the
/// OptimismPortal contract. THIS IS EXPECTED BEHAVIOR.
/// @dev NOTE: Unlike other functions in OPCM, this is a one-off function used to serve the
/// temporary need to support the interop migration action. It will likely be removed in
/// the near future once interop support is baked more directly into OPCM. It does NOT
Expand Down