Skip to content

upgrade foundry deps to 1.4.3#18923

Closed
AmadiMichael wants to merge 11 commits intodevelopfrom
amadi/foundry-1.4.3-upgrade
Closed

upgrade foundry deps to 1.4.3#18923
AmadiMichael wants to merge 11 commits intodevelopfrom
amadi/foundry-1.4.3-upgrade

Conversation

@AmadiMichael
Copy link
Copy Markdown
Contributor

@AmadiMichael AmadiMichael commented Jan 23, 2026

Upgrade foundry dependencies to 1.4.3.

  • This new version has a new linter so semver lock for file content changed for a lot of files hence the patch version bump across different files
  • This new version also has a lot of linter benefits, some of which we have scripts for, to make this PR as small as possible, i added all of them that we are currently experencing after compiling and linting into an exception list in foundry.toml which I will be using future prs to remove and fixing the resulting errors + removing our existing script for it.
  • The new lockfile, foundry.lock, tracks exact revisions for all dependencies in lib/.

Proposal PR: ethereum-optimism/design-docs#363

@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 23, 2026

Codecov Report

❌ Patch coverage is 76.56250% with 15 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.7%. Comparing base (213b398) to head (bc82ed9).
⚠️ Report is 802 commits behind head on develop.

Files with missing lines Patch % Lines
packages/contracts-bedrock/src/cannon/MIPS64.sol 0.0% 5 Missing ⚠️
...es/contracts-bedrock/src/cannon/PreimageOracle.sol 57.1% 3 Missing ⚠️
...kages/contracts-bedrock/src/libraries/SafeCall.sol 33.3% 2 Missing ⚠️
...es/contracts-bedrock/src/L1/OPContractsManager.sol 87.5% 1 Missing ⚠️
...ntracts-bedrock/src/L2/L2StandardBridgeInterop.sol 0.0% 1 Missing ⚠️
...edrock/src/cannon/libraries/MIPS64Instructions.sol 0.0% 1 Missing ⚠️
...ages/contracts-bedrock/src/libraries/Blueprint.sol 0.0% 1 Missing ⚠️
...ts-bedrock/src/libraries/trie/SecureMerkleTrie.sol 0.0% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #18923     +/-   ##
==========================================
- Coverage     76.3%    72.7%   -3.7%     
==========================================
  Files          188      188             
  Lines        10939    10962     +23     
==========================================
- Hits          8357     7978    -379     
- Misses        2436     2840    +404     
+ Partials       146      144      -2     
Flag Coverage Δ
cannon-go-tests-64 66.4% <ø> (-0.9%) ⬇️
contracts-bedrock-tests 76.4% <76.5%> (-5.3%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...racts-bedrock/src/L1/DataAvailabilityChallenge.sol 96.0% <100.0%> (-4.0%) ⬇️
...ontracts-bedrock/src/L1/L1CrossDomainMessenger.sol 100.0% <100.0%> (ø)
...ckages/contracts-bedrock/src/L1/L1ERC721Bridge.sol 100.0% <100.0%> (ø)
...ages/contracts-bedrock/src/L1/L1StandardBridge.sol 100.0% <100.0%> (ø)
...ock/src/L1/OPContractsManagerStandardValidator.sol 97.2% <100.0%> (ø)
...kages/contracts-bedrock/src/L1/OptimismPortal2.sol 98.5% <100.0%> (+<0.1%) ⬆️
...contracts-bedrock/src/L1/OptimismPortalInterop.sol 98.6% <100.0%> (+<0.1%) ⬆️
...ages/contracts-bedrock/src/L1/ProtocolVersions.sol 100.0% <100.0%> (ø)
...s/contracts-bedrock/src/L1/ProxyAdminOwnedBase.sol 100.0% <ø> (ø)
...edrock/src/L1/opcm/OPContractsManagerContainer.sol 100.0% <100.0%> (ø)
... and 35 more

... and 19 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@opgitgovernance opgitgovernance added the S-stale Status: Will be closed unless there is activity label Feb 13, 2026
@opgitgovernance
Copy link
Copy Markdown
Contributor

This pr has been automatically marked as stale and will be closed in 5 days if no updates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-stale Status: Will be closed unless there is activity

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants