refactor(op-devstack): remove backward compatibility type aliases to align on single ComponentID type

[teddyknox]

Summary

Phase 6 completes the devstack ID refactor by fully removing backward-compatibility ID aliases and using a single stack.ComponentID model everywhere.

This revision also includes follow-up compatibility fixes to keep CI healthy after the alias removal.

Why

Earlier phases kept temporary aliases so code could migrate incrementally. This PR removes that compatibility layer to finish the migration and reduce long-term complexity.

What Changed

1. Removed the legacy compatibility layer.

• Deleted op-devstack/stack/id.go.
• Removed remaining old alias-driven ID plumbing in favor of ComponentID.

2. Standardized call sites on ComponentID.

• Updated sysgo/presets call sites that still referenced removed stack.*ID aliases.
• Kept typed constructor usage (NewL1ELNodeID, NewL2ELNodeID, etc.), with those constructors now returning ComponentID directly.

3. Added explicit runtime guardrails where generic IDs are accepted.

• sysgo.WithFaucets now validates input kinds and shape early.
• It enforces non-empty L2 input, L1 kind correctness, and accepted L2 EL-capable kinds.

4. Fixed post-alias-removal fallout in test presets.

• Updated remaining rust/kona and rust/op-reth Go preset files from removed stack.*ID types to stack.ComponentID.
• Replaced stale stack.ConductorKind usage with stack.KindConductor.
• Updated one acceptance test hook signature to stack.ComponentID.

Breaking Change

This removes old alias types (for example stack.L1ELNodeID, stack.L2ELNodeID, stack.L2BatcherID, etc.). Callers should use stack.ComponentID and typed constructors.

Validation

• make lint-go
• go test ./op-devstack/stack -run '^$'
• go test ./op-devstack/sysgo -run '^$'
• go test -tags=ci -short ./op-devstack/dsl/... ./op-devstack/dsl/contract/...
• cd op-acceptance-tests && just cmd-check
• cd op-acceptance-tests && go test -v -c -o /dev/null $(go list -f '{{if .TestGoFiles}}{{.ImportPath}}{{end}}' ./tests/...)
• go test -tags=ci -c ./op-validator/pkg/validations
• go test -tags=ci -c ./op-deployer/pkg/deployer/bootstrap

Related

• Devstack ID Type System Refactor design doc

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.7%. Comparing base (ee28d5a) to head (e59baa9).
⚠️ Report is 3 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #18877      +/-   ##
===========================================
+ Coverage     75.3%    76.7%    +1.4%     
===========================================
  Files          193      536     +343     
  Lines        11256    70185   +58929     
===========================================
+ Hits          8476    53890   +45414     
- Misses        2636    16295   +13659     
+ Partials       144        0     -144     

Flag	Coverage Δ
cannon-go-tests-64	?
contracts-bedrock-tests	?
unit	76.7% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 729 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[pcw109550]

Left a few comments about the tradeoff, by losing the type info. Also added some possible runtime mitigations.

[opgitgovernance]

This pr has been automatically marked as stale and will be closed in 5 days if no updates

[ajsutton]

LGTM. Just remove the re-added files under the top level kona directory. They all seem to already exist under rust/kona