refactor(op-devstack): migrate Orchestrator to unified Registry (Phase 4)

[teddyknox]

This PR completes Phase 4 of the ID type system refactor by migrating the Orchestrator from 15 separate locks.RWMap registry fields to a single unified *stack.Registry.

Key changes:

• Replace 15 typed registry fields (l1ELs, l2CLs, batchers, etc.) with single registry *stack.Registry
• Update GetL2EL to use FindL2ELCapableByKey for polymorphic lookups across L2ELNode, RollupBoostNode, and OPRBuilderNode
• Update Hydrate method to iterate components by kind with explicit ordering
• Update all ControlPlane methods to use registry lookups with type assertions
• Migrate ~24 files to use consistent registry.Register() and registry.Get() patterns

Motivation

The previous Orchestrator maintained 15 separate locks.RWMap fields, each keyed by its own ID type:

// Before: 15 separate registries
type Orchestrator struct {
    l1ELs           locks.RWMap[stack.L1ELNodeID, L1ELNode]
    l2CLs           locks.RWMap[stack.L2CLNodeID, L2CLNode]
    batchers        locks.RWMap[stack.L2BatcherID, *L2Batcher]
    rollupBoosts    locks.RWMap[stack.RollupBoostNodeID, *RollupBoostNode]
    // ... 11 more fields
}

This led to:

• Duplicate lookup logic across registries
• Complex polymorphic lookups (GetL2EL had to check 3 different maps)
• No unified way to query "all components on chain X"
• Adding new component types required adding new registry fields

Solution

Consolidate all component storage into a single registry:

// After: Single unified registry
type Orchestrator struct {
    registry *stack.Registry
}

The registry provides:

• Primary storage: ComponentID -> component
• Secondary index by kind: ComponentKind -> []ComponentID
• Secondary index by chain: ChainID -> []ComponentID

Migration Patterns

Registration:

// Before
orch.batchers.Set(batcherID, b)

// After
orch.registry.Register(stack.ConvertL2BatcherID(batcherID).ComponentID, b)

Lookup:

// Before
batcher, ok := orch.batchers.Get(id)

// After
component, ok := orch.registry.Get(stack.ConvertL2BatcherID(id).ComponentID)
batcher := component.(*L2Batcher)

Polymorphic Lookup (using Phase 3 capabilities):

// Before: 15 lines checking 3 maps
func (o *Orchestrator) GetL2EL(id stack.L2ELNodeID) (L2ELNode, bool) {
    if el, ok := o.l2ELs.Get(id); ok { return el, true }
    rbID := stack.NewRollupBoostNodeID(id.Key(), id.ChainID())
    if rb, ok := o.rollupBoosts.Get(rbID); ok { return rb, true }
    // ... check OPRBuilder too
}

// After: 5 lines with capability interface
func (o *Orchestrator) GetL2EL(id stack.L2ELNodeID) (L2ELNode, bool) {
    capable, ok := stack.FindL2ELCapableByKey(o.registry, id.Key(), id.ChainID())
    if !ok { return nil, false }
    if el, ok := capable.(L2ELNode); ok { return el, true }
    return nil, false
}

Files Changed

Category	Files
Core	sysgo/orchestrator.go, sysgo/control_plane.go, sysgo/deployer.go
L2 EL nodes	sysgo/l2_el_opgeth.go, sysgo/l2_el_opreth.go, sysgo/l2_el_synctester.go, sysgo/rollup_boost.go, sysgo/op_rbuilder.go
L2 CL nodes	sysgo/l2_cl_opnode.go, sysgo/l2_cl_kona.go, sysgo/l2_cl_supernode.go, sysgo/l2_cl_p2p_util.go
Services	sysgo/l2_batcher.go, sysgo/l2_proposer.go, sysgo/l2_challenger.go, sysgo/faucet.go
Infrastructure	sysgo/supervisor.go, sysgo/supervisor_op.go, sysgo/supervisor_kona.go, sysgo/sync_tester.go, sysgo/test_sequencer.go
Other	sysgo/add_game_type.go, sysgo/l2_metrics_dashboard.go, sysgo/l2_network_superchain_registry.go

Special Cases

l2MetricsEndpoints: This field stores Prometheus scrape targets, not components, so it remains separate. Changed from locks.RWMap to map[string][]PrometheusMetricsTarget with sync.RWMutex.

Test Plan

• All 54 stack tests pass
• Polymorphic lookups work for RollupBoostNode and OPRBuilderNode
• Hydrate correctly initializes components in dependency order
• ControlPlane can start/stop all component types
• Build compiles without errors

Related

• Phase 1 PR: Unified ComponentID with generic wrappers
• Phase 2 PR: Unified Registry implementation
• Phase 3 PR: Capability interfaces (L2ELCapable)
• Design document

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.2%. Comparing base (aaa41a0) to head (9a4caac).
⚠️ Report is 3 commits behind head on teddyknox/id-refactor-phase3.

Additional details and impacted files

@@                       Coverage Diff                       @@
##           teddyknox/id-refactor-phase3   #18875     +/-   ##
===============================================================
- Coverage                          76.3%    73.2%   -3.2%     
===============================================================
  Files                               188      190      +2     
  Lines                             10943    10966     +23     
===============================================================
- Hits                               8356     8030    -326     
- Misses                             2441     2792    +351     
+ Partials                            146      144      -2     

Flag	Coverage Δ
cannon-go-tests-64	66.4% <ø> (-0.9%)	⬇️
contracts-bedrock-tests	77.1% <ø> (-4.5%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 20 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[opgitgovernance]

This pr has been automatically marked as stale and will be closed in 5 days if no updates

[wiz-inc-a178a98b5d]

Wiz Scan Summary

Scanner	Findings
Vulnerabilities	-
Sensitive Data	-
Secrets	-
IaC Misconfigurations	-
SAST Findings	-
Software Management Findings	-
Total	-

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

[pcw109550]

Approving with a single comment about handling supernodeIDs