Skip to content

Avoid fallback download of artifacts when not on develop#18788

Merged
maurelian merged 5 commits intodevelopfrom
jm/get-target-to-script
Jan 15, 2026
Merged

Avoid fallback download of artifacts when not on develop#18788
maurelian merged 5 commits intodevelopfrom
jm/get-target-to-script

Conversation

@maurelian
Copy link
Contributor

@maurelian maurelian commented Jan 14, 2026

Summary

Avoids the fallback download of artifacts when not on develop.

This is achieved by refactoring the get-target-branch logic from CircleCI config into a reusable script that can be sourced by the use-latest-fallback script

Changes

  • Created scripts/ops/get-target-branch.sh containing the target branch detection logic
  • Updated scripts/ops/use-latest-fallback.sh to source the new script
  • Updated scripts/checks/check-semver-diff.sh to source the new script
  • Updated .circleci/config.yml to use the new script

Benefits

  • Scripts are now self-contained and determine TARGET_BRANCH themselves
  • Can be tested locally without CircleCI environment variables
  • Single source of truth for target branch logic
  • Less duplication in CircleCI config

@maurelian maurelian requested review from a team as code owners January 14, 2026 20:56
@maurelian maurelian force-pushed the jm/get-target-to-script branch from 592a6b6 to 088a5fb Compare January 14, 2026 21:01
@maurelian maurelian changed the title Refactor get-target-branch logic into reusable script Avoid fallback download of artifacts when not on develop Jan 14, 2026
@maurelian maurelian force-pushed the jm/get-target-to-script branch from d2de29f to 46de590 Compare January 15, 2026 18:27
@maurelian maurelian enabled auto-merge January 15, 2026 18:27
@maurelian maurelian added this pull request to the merge queue Jan 15, 2026
@codecov
Copy link

codecov bot commented Jan 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 76.3%. Comparing base (aa2b4d3) to head (46de590).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files
@@            Coverage Diff             @@
##           develop   #18788     +/-   ##
==========================================
- Coverage     76.3%    76.3%   -0.1%     
==========================================
  Files          560      560             
  Lines        53363    53363             
==========================================
- Hits         40739    40733      -6     
- Misses       12480    12486      +6     
  Partials       144      144             
Flag Coverage Δ
cannon-go-tests-64 66.4% <ø> (ø)
contracts-bedrock-tests 77.6% <ø> (ø)
unit 77.0% <ø> (-0.1%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 4 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Merged via the queue into develop with commit 9f95b89 Jan 15, 2026
127 checks passed
@maurelian maurelian deleted the jm/get-target-to-script branch January 15, 2026 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants