Avoid fallback download of artifacts when not on develop#18788
Merged
Avoid fallback download of artifacts when not on develop#18788
Conversation
592a6b6 to
088a5fb
Compare
serpixel
approved these changes
Jan 14, 2026
aliersh
approved these changes
Jan 14, 2026
4b7bf56 to
d2de29f
Compare
alcueca
approved these changes
Jan 15, 2026
smartcontracts
approved these changes
Jan 15, 2026
Removed unnecessary error handling and conditional logic to keep the script closer to the original CircleCI implementation for easier review.
d2de29f to
46de590
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #18788 +/- ##
==========================================
- Coverage 76.3% 76.3% -0.1%
==========================================
Files 560 560
Lines 53363 53363
==========================================
- Hits 40739 40733 -6
- Misses 12480 12486 +6
Partials 144 144
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Avoids the fallback download of artifacts when not on
develop.This is achieved by refactoring the
get-target-branchlogic from CircleCI config into a reusable script that can be sourced by theuse-latest-fallbackscriptChanges
scripts/ops/get-target-branch.shcontaining the target branch detection logicscripts/ops/use-latest-fallback.shto source the new scriptscripts/checks/check-semver-diff.shto source the new script.circleci/config.ymlto use the new scriptBenefits