op-e2e: Add interop program utilizing EIP-2935 action test#18781
Merged
op-e2e: Add interop program utilizing EIP-2935 action test#18781
Conversation
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #18781 +/- ##
===========================================
+ Coverage 76.4% 77.0% +0.6%
===========================================
Files 560 370 -190
Lines 53363 42045 -11318
===========================================
- Hits 40799 32400 -8399
+ Misses 12418 9645 -2773
+ Partials 146 0 -146
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Introduces an action test that asserts EIP-2935 utilization inside the interop fault proof program. This ensures that during consolidation, the program is able to efficiently locate historical blocks via EIP-2935.
Inphi
force-pushed
the
inphi/action-test-eip2935
branch
from
e8a6af2 to
748d661
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Interop consolidation must be able to verify canonical data for blocks far behind the current tip. With Isthmus/EIP-2935, those lookups should be sublinear (O(distance/8191)) instead of linear.
To ensure this, an action test,
TestInteropFaultProofs_DeepCanonicalBlockQuery, is introduced. This action test is designed to be program agnostic, and is compatible with an external kona program when theKONA_HOST_PATHenv is set.Testing notes
Running the action test on the kona program fails. Likely due to hypothesis explained in #18288. That said, the kona program appears to hang forever instead of merely taking longer due to the linear walk back. So it's quite possible that the kona-interop does not handle this case well at all. More investigation will be needed but that's outside the scope of this PR.
fixes #18505