Skip to content

test(contracts): improve OptimismMintableERC20Factory test coverage #18707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JosepBove merged 2 commits into from
Jan 7, 2026
Merged

test(contracts): improve OptimismMintableERC20Factory test coverage #18707

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f9c597
refactor(test): rename fuzz tests to use testFuzz_ prefix in Optimism…
devin-ai-integration[bot] Jan 1, 2026
e1d13ee
test(contracts): add tests for createOptimismMintableERC20 and versio…
devin-ai-integration[bot] Jan 1, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
87 changes: 77 additions & 10 deletions packages/contracts-bedrock/test/universal/OptimismMintableERC20Factory.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ import { EIP1967Helper } from "test/mocks/EIP1967Helper.sol";
import { OptimismMintableERC20 } from "src/universal/OptimismMintableERC20.sol";
import { OptimismMintableERC20Factory } from "src/universal/OptimismMintableERC20Factory.sol";

// Libraries
import { SemverComp } from "src/libraries/SemverComp.sol";

// Interfaces
import { IProxy } from "interfaces/universal/IProxy.sol";
import { IOptimismMintableERC20Factory } from "interfaces/universal/IOptimismMintableERC20Factory.sol";
Expand Down Expand Up @@ -67,7 +70,7 @@ contract OptimismMintableERC20Factory_Initialize_Test is OptimismMintableERC20Fa
/// contract.
contract OptimismMintableERC20Factory_CreateStandardL2Token_Test is OptimismMintableERC20Factory_TestInit {
/// @notice Test that calling `createStandardL2Token` with valid parameters succeeds.
function test_createStandardL2Token_succeeds(
function testFuzz_createStandardL2Token_validParams_succeeds(
address _caller,
address _remoteToken,
string memory _name,
Expand Down Expand Up @@ -100,7 +103,7 @@ contract OptimismMintableERC20Factory_CreateStandardL2Token_Test is OptimismMint

/// @notice Test that calling `createOptimismMintableERC20WithDecimals` with valid parameters
/// succeeds.
function test_createStandardL2TokenWithDecimals_succeeds(
function testFuzz_createOptimismMintableERC20WithDecimals_validParams_succeeds(
address _caller,
address _remoteToken,
string memory _name,
Expand Down Expand Up @@ -134,7 +137,7 @@ contract OptimismMintableERC20Factory_CreateStandardL2Token_Test is OptimismMint
}

/// @notice Test that calling `createStandardL2Token` with the same parameters twice reverts.
function test_createStandardL2Token_sameTwice_reverts(
function testFuzz_createStandardL2Token_sameTwice_reverts(
address _caller,
address _remoteToken,
string memory _name,
Expand All @@ -156,9 +159,9 @@ contract OptimismMintableERC20Factory_CreateStandardL2Token_Test is OptimismMint
l2OptimismMintableERC20Factory.createStandardL2Token(_remoteToken, _name, _symbol);
}

/// @notice Test that calling `createStandardL2TokenWithDecimals` with the same parameters
/// twice reverts.
function test_createStandardL2TokenWithDecimals_sameTwice_reverts(
/// @notice Test that calling `createOptimismMintableERC20WithDecimals` with the same
/// parameters twice reverts.
function testFuzz_createOptimismMintableERC20WithDecimals_sameTwice_reverts(
address _caller,
address _remoteToken,
string memory _name,
Expand All @@ -182,7 +185,7 @@ contract OptimismMintableERC20Factory_CreateStandardL2Token_Test is OptimismMint
}

/// @notice Test that calling `createStandardL2Token` with a zero remote token address reverts.
function test_createStandardL2Token_remoteIsZero_reverts(
function testFuzz_createStandardL2Token_remoteIsZero_reverts(
address _caller,
string memory _name,
string memory _symbol
Expand All @@ -198,9 +201,9 @@ contract OptimismMintableERC20Factory_CreateStandardL2Token_Test is OptimismMint
l2OptimismMintableERC20Factory.createStandardL2Token(remote, _name, _symbol);
}

/// @notice Test that calling `createStandardL2TokenWithDecimals` with a zero remote token
/// address reverts.
function test_createStandardL2TokenWithDecimals_remoteIsZero_reverts(
/// @notice Test that calling `createOptimismMintableERC20WithDecimals` with a zero remote
/// token address reverts.
function testFuzz_createOptimismMintableERC20WithDecimals_remoteIsZero_reverts(
address _caller,
string memory _name,
string memory _symbol,
Expand All @@ -218,6 +221,70 @@ contract OptimismMintableERC20Factory_CreateStandardL2Token_Test is OptimismMint
}
}

/// @title OptimismMintableERC20Factory_CreateOptimismMintableERC20_Test
/// @notice Tests the `createOptimismMintableERC20` function of the `OptimismMintableERC20Factory`
/// contract.
contract OptimismMintableERC20Factory_CreateOptimismMintableERC20_Test is OptimismMintableERC20Factory_TestInit {
/// @notice Test that calling `createOptimismMintableERC20` with valid parameters succeeds.
function testFuzz_createOptimismMintableERC20_validParams_succeeds(
address _caller,
address _remoteToken,
string memory _name,
string memory _symbol
)
external
{
// Assume
vm.assume(_remoteToken != address(0));

// Arrange
// createOptimismMintableERC20 defaults to 18 decimals
address local = _calculateTokenAddress(_remoteToken, _name, _symbol, 18);

vm.expectEmit(address(l2OptimismMintableERC20Factory));
emit StandardL2TokenCreated(_remoteToken, local);

vm.expectEmit(address(l2OptimismMintableERC20Factory));
emit OptimismMintableERC20Created(local, _remoteToken, _caller);

// Act
vm.prank(_caller);
address addr = l2OptimismMintableERC20Factory.createOptimismMintableERC20(_remoteToken, _name, _symbol);

// Assert
assertTrue(addr == local);
assertTrue(OptimismMintableERC20(local).decimals() == 18);
assertEq(l2OptimismMintableERC20Factory.deployments(local), _remoteToken);
}

/// @notice Test that calling `createOptimismMintableERC20` with a zero remote token address
/// reverts.
function testFuzz_createOptimismMintableERC20_remoteIsZero_reverts(
address _caller,
string memory _name,
string memory _symbol
)
external
{
// Arrange
address remote = address(0);
vm.expectRevert("OptimismMintableERC20Factory: must provide remote token address");

// Act
vm.prank(_caller);
l2OptimismMintableERC20Factory.createOptimismMintableERC20(remote, _name, _symbol);
}
}

/// @title OptimismMintableERC20Factory_Version_Test
/// @notice Tests the `version` function of the `OptimismMintableERC20Factory` contract.
contract OptimismMintableERC20Factory_Version_Test is OptimismMintableERC20Factory_TestInit {
/// @notice Tests that version returns a valid semver string.
function test_version_validFormat_succeeds() external view {
SemverComp.parse(l2OptimismMintableERC20Factory.version());
}
}

/// @title OptimismMintableERC20Factory_Uncategorized_Test
/// @notice General tests that are not testing any function directly of the
/// `OptimismMintableERC20Factory` contract.
Expand Down