tests(op-node): Add coverage for future/unknown SystemConfig events#18566
Merged
tests(op-node): Add coverage for future/unknown SystemConfig events#18566
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #18566 +/- ##
===========================================
+ Coverage 75.78% 80.46% +4.68%
===========================================
Files 189 134 -55
Lines 11239 7208 -4031
===========================================
- Hits 8517 5800 -2717
+ Misses 2576 1408 -1168
+ Partials 146 0 -146
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Add ErrUnknownEventVersion and ErrUnknownEventType and return wrapped typed errors (%w) when encountering unknown event versions or types. Replace NewCriticalError for ErrParsingSystemConfig with a plain error. Update tests to assert errors with require.ErrorIs and adjust event topics/data accordingly.
geoknee
commented
Dec 10, 2025
geoknee
changed the title
![almanax-ai[bot]](https://avatars.githubusercontent.com/in/934833?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://www.notion.so/oplabs/P-PS-Allow-CL-clients-to-parse-future-SystemConfig-ConfigUpdate-events-without-critical-error-269f153ee16280fe9c5eec1e7b6640aa?source=copy_link
Follow up to #18292