Skip to content

feat: contract check runner#18553

Merged
smartcontracts merged 8 commits intodevelopfrom
sc/check-runner
Dec 9, 2025
Merged

feat: contract check runner#18553
smartcontracts merged 8 commits intodevelopfrom
sc/check-runner

Conversation

@smartcontracts
Copy link
Copy Markdown
Contributor

@smartcontracts smartcontracts commented Dec 9, 2025

Description
Adds a new tool for executing checks in the contracts repo. Adding this as a secondary tool for now, along with a CI job that runs all the checks. Aiming to slowly fade out the existing check system.

Note: this is a Claude-heavy PR, but it works very well

@smartcontracts smartcontracts requested a review from a team as a code owner December 9, 2025 05:22
@smartcontracts smartcontracts requested review from a team, agusduha and geoknee December 9, 2025 05:22
@wiz-inc-a178a98b5d
Copy link
Copy Markdown

wiz-inc-a178a98b5d Bot commented Dec 9, 2025

Wiz Scan Summary

Scanner Findings
Vulnerability Finding Vulnerabilities -
Data Finding Sensitive Data -
Secret Finding Secrets -
IaC Misconfiguration IaC Misconfigurations -
SAST Finding SAST Findings 8 Medium
Total 8 Medium

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 9, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.44%. Comparing base (a1e78ba) to head (8bb123f).
⚠️ Report is 6 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #18553      +/-   ##
===========================================
- Coverage    75.76%   75.44%   -0.33%     
===========================================
  Files          189      189              
  Lines        11233    11233              
===========================================
- Hits          8511     8475      -36     
- Misses        2576     2614      +38     
+ Partials       146      144       -2     
Flag Coverage Δ
cannon-go-tests-64 66.58% <ø> (-0.82%) ⬇️
contracts-bedrock-tests 80.40% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 6 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@smartcontracts
Copy link
Copy Markdown
Contributor Author

Reviewed the Wiz findings, they're all overly cautious and just expected behavior of the script

Comment thread packages/contracts-bedrock/justfile
Comment thread packages/contracts-bedrock/checks.yaml
Comment thread packages/contracts-bedrock/justfile
@smartcontracts smartcontracts added this pull request to the merge queue Dec 9, 2025
Merged via the queue into develop with commit 72d003c Dec 9, 2025
172 checks passed
@smartcontracts smartcontracts deleted the sc/check-runner branch December 9, 2025 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants