Skip to content

fix: fuzz failure in system config test #18550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mds1 merged 2 commits into from
Dec 9, 2025
Merged

fix: fuzz failure in system config test #18550

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
77d95d5
fix: fuzz failure in system config test
smartcontracts Dec 8, 2025
c5818f5
fix: proper skip
smartcontracts Dec 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions packages/contracts-bedrock/test/L1/SystemConfig.t.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -867,15 +867,17 @@ contract SystemConfig_IsFeatureEnabled_Test is SystemConfig_TestInit {
/// @notice Tests that `isFeatureEnabled` returns false for unset features.
/// @param _feature The feature to check.
function testFuzz_isFeatureEnabled_unsetFeature_succeeds(bytes32 _feature) external {
vm.startPrank(address(systemConfig.proxyAdmin()));
if (_feature == Features.ETH_LOCKBOX && systemConfig.isFeatureEnabled(Features.ETH_LOCKBOX)) {
// Needs to be anything but ETH_LOCKBOX because we can't turn that feature off if it's on.
vm.skip(true);
}

// Normalize CUSTOM_GAS_TOKEN to avoid environment-dependent state
if (systemConfig.isFeatureEnabled(Features.CUSTOM_GAS_TOKEN)) {
vm.prank(address(systemConfig.proxyAdmin()));
systemConfig.setFeature(Features.CUSTOM_GAS_TOKEN, false);
}

vm.stopPrank();

assertFalse(systemConfig.isFeatureEnabled(_feature));
}

Expand Down