Skip to content

feat: have SystemConfig store a ref to last used OPCM#18547

Merged
smartcontracts merged 2 commits intodevelopfrom
sc/syscfg-opcm-version
Dec 9, 2025
Merged

feat: have SystemConfig store a ref to last used OPCM#18547
smartcontracts merged 2 commits intodevelopfrom
sc/syscfg-opcm-version

Conversation

@smartcontracts
Copy link
Copy Markdown
Contributor

Description
Updates SystemConfig to accept a new opcm input variable during initialization. This represents the OPCM contract that was last used to upgrade the system and can therefore be used to determine which L1 contract release this system is using.

@smartcontracts smartcontracts requested a review from a team as a code owner December 8, 2025 22:06
Comment thread packages/contracts-bedrock/src/L1/SystemConfig.sol
Comment thread packages/contracts-bedrock/src/L1/SystemConfig.sol
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.53%. Comparing base (c15a2ef) to head (0281eda).
⚠️ Report is 4 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #18547      +/-   ##
===========================================
+ Coverage    75.47%   79.53%   +4.06%     
===========================================
  Files          189      134      -55     
  Lines        11233     7208    -4025     
===========================================
- Hits          8478     5733    -2745     
+ Misses        2611     1475    -1136     
+ Partials       144        0     -144     
Flag Coverage Δ
cannon-go-tests-64 ?
contracts-bedrock-tests 79.53% <100.00%> (-0.92%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...es/contracts-bedrock/src/L1/OPContractsManager.sol 93.69% <100.00%> (ø)
packages/contracts-bedrock/src/L1/SystemConfig.sol 95.45% <100.00%> (+0.15%) ⬆️
...racts-bedrock/src/L1/opcm/OPContractsManagerV2.sol 94.61% <100.00%> (+0.04%) ⬆️

... and 57 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@smartcontracts smartcontracts added this pull request to the merge queue Dec 9, 2025
Merged via the queue into develop with commit 727890b Dec 9, 2025
171 checks passed
@smartcontracts smartcontracts deleted the sc/syscfg-opcm-version branch December 9, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants