Skip to content

ci: reduce permissions of fork builds & fix tag releases#18501

Merged
falcorocks merged 1 commit intodevelopfrom
falco/refactor-docker-workflows
Dec 5, 2025
Merged

ci: reduce permissions of fork builds & fix tag releases#18501
falcorocks merged 1 commit intodevelopfrom
falco/refactor-docker-workflows

Conversation

@falcorocks
Copy link
Copy Markdown
Contributor

@falcorocks falcorocks commented Dec 4, 2025

Summary

  1. Fix how we release tags to match CircleCI. Currently when we issue tag op-node/abc the GHA workflow builds all images with tag op-node-abc.
  2. Split the docker CI workflows in 3 paths:
  • tags.yaml: handles release tag pushes (push to GCP registry, attest)
  • branches.yaml: distinguishes between local PRs and fork PRs
    • local -> push to GCP registry, attest
    • fork -> push to ttl.sh, no attest, minimal permissions

@falcorocks falcorocks self-assigned this Dec 4, 2025
@falcorocks falcorocks changed the title refactor(ci): split docker workflows into tags.yaml and branches.yaml ci: reduce permissions of fork builds Dec 4, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.32%. Comparing base (c0d1ce8) to head (070ffef).
⚠️ Report is 11 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #18501      +/-   ##
===========================================
- Coverage    75.62%   75.32%   -0.30%     
===========================================
  Files          187      187              
  Lines        11199    11199              
===========================================
- Hits          8469     8436      -33     
- Misses        2584     2619      +35     
+ Partials       146      144       -2     
Flag Coverage Δ
cannon-go-tests-64 66.58% <ø> (-0.82%) ⬇️
contracts-bedrock-tests 80.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@falcorocks falcorocks changed the title ci: reduce permissions of fork builds ci: reduce permissions of fork builds & fix tag releases Dec 4, 2025
@falcorocks falcorocks force-pushed the falco/refactor-docker-workflows branch from d76a7fc to 070ffef Compare December 5, 2025 09:34
@falcorocks falcorocks marked this pull request as ready for review December 5, 2025 09:38
@falcorocks falcorocks requested review from a team and smartcontracts December 5, 2025 09:38
@falcorocks falcorocks added this pull request to the merge queue Dec 5, 2025
Merged via the queue into develop with commit 532d1e4 Dec 5, 2025
167 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants