Skip to content

small tweaks to TestRequestDuplicateBlobHashes#18497

Merged
geoknee merged 1 commit intodevelopfrom
gk/duplicate-blob-test-tweak
Dec 4, 2025
Merged

small tweaks to TestRequestDuplicateBlobHashes#18497
geoknee merged 1 commit intodevelopfrom
gk/duplicate-blob-test-tweak

Conversation

@geoknee
Copy link
Copy Markdown
Contributor

@geoknee geoknee commented Dec 4, 2025

  • Removes some unecessary code which could be confusing
  • Adds higher level assertions which are more helpful when there is a bug

@geoknee geoknee requested review from a team and sebastianst December 4, 2025 09:34
@geoknee geoknee enabled auto-merge December 4, 2025 09:43
@geoknee geoknee added this pull request to the merge queue Dec 4, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.00%. Comparing base (478b8bd) to head (c5973f6).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #18497      +/-   ##
===========================================
+ Coverage    75.22%   80.00%   +4.77%     
===========================================
  Files          187      132      -55     
  Lines        11199     7168    -4031     
===========================================
- Hits          8425     5735    -2690     
+ Misses        2628     1433    -1195     
+ Partials       146        0     -146     
Flag Coverage Δ
cannon-go-tests-64 ?
contracts-bedrock-tests 80.00% <ø> (+0.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 57 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Merged via the queue into develop with commit 653c6a6 Dec 4, 2025
84 checks passed
@geoknee geoknee deleted the gk/duplicate-blob-test-tweak branch December 4, 2025 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants