op-service/sources: detect duplicate blob hashes#18492
Merged
Conversation
![almanax-ai[bot]](https://avatars.githubusercontent.com/in/934833?s=60&v=4){kind=small}
sebastianst
commented
Dec 4, 2025
Member
Author
sebastianst
left a comment
sebastianst
left a comment
There was a problem hiding this comment.
@ajsutton fixes and tests look good to me!
ajsutton
approved these changes
Dec 4, 2025
ajsutton
force-pushed
the
seb/fix-l1-blob-source
branch
from
2b2689c to
e3df253
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Update blob fetching logic to handle the case where multiple blobs with the same content (but different indices in the block) are requested. When reordering the blob responses matching was done purely on blob hash which meant some output blobs were written twice and some not set at all. This resulted in an error about nil blobs. The fix is to assign to a blob hash request that hasn't previously been set.
Tests
Added unit test.