feat(op-deployer): use op-deployer build for publish-artifacts#18488
Merged
feat(op-deployer): use op-deployer build for publish-artifacts#18488
Conversation
bitwiseguy
reviewed
Dec 3, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #18488 +/- ##
===========================================
+ Coverage 75.71% 75.90% +0.19%
===========================================
Files 189 134 -55
Lines 11228 7197 -4031
===========================================
- Hits 8501 5463 -3038
+ Misses 2581 1734 -847
+ Partials 146 0 -146
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
falcorocks
added a commit
to ethereum-optimism/factory
that referenced
this pull request
Dec 4, 2025
Use quoted heredoc to safely write bake metadata to file before processing. This prevents bash history expansion issues when metadata contains special characters like '!' which can cause 'No such file or directory' errors. Fixes flaky CI failures observed in ethereum-optimism/optimism#18488
falcorocks
added a commit
to ethereum-optimism/factory
that referenced
this pull request
Dec 4, 2025
…on (#8) Use quoted heredoc to safely write bake metadata to file before processing. This prevents bash history expansion issues when metadata contains special characters like '!' which can cause 'No such file or directory' errors. Fixes flaky CI failures observed in ethereum-optimism/optimism#18488
serpixel
force-pushed
the
fix/op-deployer/reuse-op-deployer-artifacts
branch
from
e6a468a to
36e00f3
Compare
maurelian
approved these changes
Dec 4, 2025
smartcontracts
approved these changes
Dec 5, 2025
serpixel
added a commit
that referenced
this pull request
Dec 8, 2025
* feat(op-deployer): use op-deployer build for publish-artifacts * fix(op-deployer): restore bucket name * fix(op-deployer): add COMMIT file * fix(op-deployer): verify cli test
serpixel
added a commit
that referenced
this pull request
Dec 10, 2025
* feat(op-deployer): use op-deployer build for publish-artifacts * fix(op-deployer): restore bucket name * fix(op-deployer): add COMMIT file * fix(op-deployer): verify cli test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Switches to op-deployer's build and compress command for consistency. This also enables the uploaded artifacts to be used for verification.
Tests
Additional context
Metadata