Skip to content

test: add tests for OPCMv2.deploy#18486

Merged
smartcontracts merged 5 commits intodevelopfrom
sc/opcm-deploy-tests
Dec 5, 2025
Merged

test: add tests for OPCMv2.deploy#18486
smartcontracts merged 5 commits intodevelopfrom
sc/opcm-deploy-tests

Conversation

@smartcontracts
Copy link
Copy Markdown
Contributor

Description
Adds new tests for OPCMv2.deploy

@smartcontracts smartcontracts requested a review from a team as a code owner December 3, 2025 16:44
@smartcontracts smartcontracts requested a review from tynes December 3, 2025 16:44
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 3, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.46%. Comparing base (c59e981) to head (faae6eb).
⚠️ Report is 6 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #18486      +/-   ##
===========================================
- Coverage    75.71%   75.46%   -0.25%     
===========================================
  Files          189      189              
  Lines        11228    11228              
===========================================
- Hits          8501     8473      -28     
- Misses        2581     2611      +30     
+ Partials       146      144       -2     
Flag Coverage Δ
cannon-go-tests-64 66.58% <ø> (-0.82%) ⬇️
contracts-bedrock-tests 80.43% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread packages/contracts-bedrock/test/L1/opcm/OPContractsManagerV2.t.sol
Comment thread packages/contracts-bedrock/test/L1/opcm/OPContractsManagerV2.t.sol
@smartcontracts smartcontracts requested a review from a team December 3, 2025 19:27
@maurelian maurelian self-assigned this Dec 3, 2025
Comment thread packages/contracts-bedrock/test/L1/opcm/OPContractsManagerV2.t.sol
Comment thread packages/contracts-bedrock/test/L1/opcm/OPContractsManagerV2.t.sol
Comment thread packages/contracts-bedrock/test/L1/opcm/OPContractsManagerV2.t.sol
Copy link
Copy Markdown
Contributor

@maurelian maurelian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments, but no blockers.

Copy link
Copy Markdown
Contributor

@0xOneTony 0xOneTony left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread packages/contracts-bedrock/test/L1/opcm/OPContractsManagerV2.t.sol
@smartcontracts smartcontracts force-pushed the sc/opcm-deploy-tests branch 2 times, most recently from 725f544 to 1ac2854 Compare December 5, 2025 17:38
@smartcontracts smartcontracts added this pull request to the merge queue Dec 5, 2025
Merged via the queue into develop with commit 3377668 Dec 5, 2025
170 of 171 checks passed
@smartcontracts smartcontracts deleted the sc/opcm-deploy-tests branch December 5, 2025 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants