Skip to content

op-challenger: Stop bundling asterisc#18476

Merged
ajsutton merged 2 commits intodevelopfrom
aj/remove-asterisc
Dec 2, 2025
Merged

op-challenger: Stop bundling asterisc#18476
ajsutton merged 2 commits intodevelopfrom
aj/remove-asterisc

Conversation

@ajsutton
Copy link
Copy Markdown
Contributor

@ajsutton ajsutton commented Dec 2, 2025

Description

Stop bundling asterisc with the op-challenger docker image. Remove asterisc-kona from default game types.

Tests

Updated unit tests. Manually confirmed the asterisc CLI options are not required.

@ajsutton ajsutton requested review from a team and Inphi December 2, 2025 23:16
@ajsutton ajsutton enabled auto-merge December 2, 2025 23:27
@ajsutton ajsutton added this pull request to the merge queue Dec 2, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 2, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.24%. Comparing base (fcd09d5) to head (bd9f837).
⚠️ Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #18476      +/-   ##
===========================================
- Coverage    75.62%   75.24%   -0.38%     
===========================================
  Files          187      187              
  Lines        11199    11199              
===========================================
- Hits          8469     8427      -42     
- Misses        2584     2628      +44     
+ Partials       146      144       -2     
Flag Coverage Δ
cannon-go-tests-64 66.58% <ø> (-0.82%) ⬇️
contracts-bedrock-tests 80.11% <ø> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 7 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Merged via the queue into develop with commit 813b8cd Dec 2, 2025
133 checks passed
@ajsutton ajsutton deleted the aj/remove-asterisc branch December 2, 2025 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants