feat: add cgt to opcmv2#18455
Merged
smartcontracts merged 42 commits intoethereum-optimism:developfrom Dec 11, 2025
Merged
Conversation
* feat: add cgt to opcmv2 * fix: change semver
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
maurelian
reviewed
Dec 1, 2025
maurelian
reviewed
Dec 1, 2025
Contributor
* feat: add cgt to opcmv2 * fix: change semver
feat: ocpm2 cgt rebase
Contributor
|
/ci authorize c372ddc |
maurelian
approved these changes
Dec 2, 2025
AmadiMichael
reviewed
Dec 2, 2025
Contributor
AmadiMichael
left a comment
AmadiMichael
left a comment
There was a problem hiding this comment.
LGTM, though i do not see a corresponding test added for this, do we plan on adding it in a future pr?
Contributor
|
Good point, @0xniha can you add a new CI matrix config that runs OPCMv2 and CGT at the same time? |
Contributor
|
/ci authorize 457e671 |
Conflicts: .circleci/config.yml
sync: Add CGT with develop
Contributor
|
/ci authorize df3ecf5 |
Contributor
|
The tests failing seem not to be specific for CGT, I think it makes sense to fix those in a different PR. |
* fix: check CGT is not enabled before enabling it * fix: enable CGT overrides
Contributor
|
/ci authorize 2614984 |
* feat: add cgt to opcmv2 * fix: change semver
* feat: add cgt to opcmv2 * fix: change semver
* fix: check CGT is not enabled before enabling it * fix: enable CGT overrides
* fix: add check enabled CGT during upgrades * test: set CGT false by default during forked tests * chore: expand comment on OPCMv2 regarding CGT
chore: opcm2 cgt sync
Conflicts: packages/contracts-bedrock/interfaces/L1/opcm/IOPContractsManagerV2.sol packages/contracts-bedrock/snapshots/semver-lock.json packages/contracts-bedrock/src/L1/opcm/OPContractsManagerV2.sol
chore: sync sc-feat/opcm2-add-cgt with develop
chore: Merge develop into sc-feat/opcm2-add-cgt
Contributor
|
/ci authorize 550f2be |
packages/contracts-bedrock/src/L1/opcm/OPContractsManagerV2.sol
Outdated
Show resolved
Hide resolved
* refactor: add helper function to match instruction by key only * chore: pre-pr ready * test: refactor key matching test * test: add test suite for IsMatchingKey helper function * chore: pre-pr ready
smartcontracts
approved these changes
Dec 10, 2025
Contributor
|
/ci authorize 7aea894 |
Contributor
|
/ci authorize 6cee90f |
smartcontracts
approved these changes
Dec 11, 2025
Merged
via the queue into
ethereum-optimism:develop
with commit Dec 11, 2025
adf9b32
177 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
useCustomGasTokeninput toFullConfigstruct.SystemConfigif flag enabled.