Skip to content

feat: break out OPCMv2 utils into helper contracts#18454

Merged
maurelian merged 10 commits into
developfrom
sc/opcm-utility
Dec 4, 2025
Merged

feat: break out OPCMv2 utils into helper contracts#18454
maurelian merged 10 commits into
developfrom
sc/opcm-utility

Conversation

@smartcontracts
Copy link
Copy Markdown
Contributor

Breaks out the OPCMv2 utils into a separate Utils contract that reduces the code size of OPCMv2 significantly.

@smartcontracts smartcontracts requested a review from a team as a code owner December 1, 2025 19:02
@smartcontracts smartcontracts requested review from a team, bitwiseguy and stevennevins December 1, 2025 19:02
@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 1, 2025

Codecov Report

❌ Patch coverage is 97.82609% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.36%. Comparing base (3e33e14) to head (5b1a09f).
⚠️ Report is 24 commits behind head on develop.

Files with missing lines Patch % Lines
...rock/src/L1/opcm/OPContractsManagerUtilsCaller.sol 91.66% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #18454      +/-   ##
===========================================
+ Coverage    75.62%   80.36%   +4.74%     
===========================================
  Files          187      134      -53     
  Lines        11199     7197    -4002     
===========================================
- Hits          8469     5784    -2685     
+ Misses        2584     1413    -1171     
+ Partials       146        0     -146     
Flag Coverage Δ
cannon-go-tests-64 ?
contracts-bedrock-tests 80.36% <97.82%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ts-bedrock/src/L1/opcm/OPContractsManagerUtils.sol 100.00% <100.00%> (ø)
...racts-bedrock/src/L1/opcm/OPContractsManagerV2.sol 91.33% <100.00%> (+0.03%) ⬆️
...ages/contracts-bedrock/src/libraries/Constants.sol 100.00% <ø> (ø)
...rock/src/L1/opcm/OPContractsManagerUtilsCaller.sol 91.66% <91.66%> (ø)

... and 55 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Comment thread packages/contracts-bedrock/src/L1/opcm/OPContractsManagerV2.sol
Breaks out the OPCMv2 utils into a separate Utils contract that
reduces the code size of OPCMv2 significantly.
Copy link
Copy Markdown
Contributor

@0xiamflux 0xiamflux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread packages/contracts-bedrock/src/L1/opcm/OPContractsManagerUtils.sol
Comment thread packages/contracts-bedrock/src/L1/opcm/OPContractsManagerUtils.sol Outdated
Comment thread packages/contracts-bedrock/src/L1/opcm/OPContractsManagerUtils.sol
Copy link
Copy Markdown
Contributor

@AmadiMichael AmadiMichael left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, might need to rerun a ci task

@maurelian maurelian self-assigned this Dec 3, 2025
@maurelian maurelian enabled auto-merge December 3, 2025 21:33
@maurelian maurelian added this pull request to the merge queue Dec 4, 2025
Merged via the queue into develop with commit 22a35b4 Dec 4, 2025
133 checks passed
@maurelian maurelian deleted the sc/opcm-utility branch December 4, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants