Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2546,7 +2546,6 @@ workflows:
- main
- OPTIMISM_PORTAL_INTEROP
- CANNON_KONA,DEPLOY_V2_DISPUTE_GAMES
- CUSTOM_GAS_TOKEN
- OPCM_V2
context:
- circleci-repo-readonly-authenticated-github-token
Expand Down
3 changes: 0 additions & 3 deletions op-deployer/pkg/deployer/devfeatures.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,6 @@ var (

// DeployV2DisputeGamesDevFlag enables deployment of V2 dispute game contracts.
DeployV2DisputeGamesDevFlag = common.HexToHash("0x0000000000000000000000000000000000000000000000000000000000000100")

// CustomGasTokenDevFlag enables the custom gas token.
CustomGasTokenDevFlag = common.HexToHash("0x0000000000000000000000000000000000000000000000000000000000001000")
)

// IsDevFeatureEnabled checks if a specific development feature is enabled in a feature bitmap.
Expand Down
4 changes: 0 additions & 4 deletions op-deployer/pkg/deployer/integration_test/apply_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -321,10 +321,6 @@ func TestEndToEndApply(t *testing.T) {
Symbol: "CGT",
InitialLiquidity: (*hexutil.Big)(amount),
}
// CGT config for OPCM
intent.GlobalDeployOverrides = map[string]interface{}{
"devFeatureBitmap": deployer.CustomGasTokenDevFlag,
}

require.NoError(t, deployer.ApplyPipeline(ctx, deployer.ApplyPipelineOpts{
DeploymentTarget: deployer.DeploymentTargetLive,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -98,5 +98,12 @@ contracts = [
"TransactionBuilder", # Transaction builder helper library in TimelockGuard test file
"Constants_Test", # Invalid naming pattern - doesn't specify function or Uncategorized
"LivenessModule2_TestUtils", # Test utils library in LivenessModule2 test file
"L1Block_SetCustomGasToken_Test", # Custom gas token tests hosted in the L1Block test file
"L1BlockCGT_TestInit", # Test initialization contract for L1BlockCGT tests
"L1BlockCGT_GasPayingToken_Test", # Custom gas token tests hosted in the L1Block test file
"L1BlockCGT_GasPayingTokenName_Test", # Custom gas token tests hosted in the L1Block test file
"L1BlockCGT_GasPayingTokenSymbol_Test", # Custom gas token tests hosted in the L1Block test file
"L1BlockCGT_IsCustomGasToken_Test", # Custom gas token tests hosted in the L1Block test file
"L1BlockCGT_SetCustomGasToken_Test", # Custom gas token tests hosted in the L1Block test file
"L2ToL1MessagePasserCGT_TestInit", # Test initialization contract for L2ToL1MessagePasserCGT tests
"L2ToL1MessagePasserCGT_InitiateWithdrawal_Test", # Custom gas token tests hosted in the L2ToL1MessagePasser test file
]
5 changes: 0 additions & 5 deletions packages/contracts-bedrock/scripts/libraries/Config.sol
Original file line number Diff line number Diff line change
Expand Up @@ -286,11 +286,6 @@ library Config {
return vm.envOr("DEV_FEATURE__DEPLOY_V2_DISPUTE_GAMES", false);
}

/// @notice Returns true if the development feature custom gas token is enabled.
function devFeatureCustomGasToken() internal view returns (bool) {
return vm.envOr("DEV_FEATURE__CUSTOM_GAS_TOKEN", false);
}

/// @notice Returns true if the development feature opcm_v2 is enabled.
function devFeatureOpcmV2() internal view returns (bool) {
return vm.envOr("DEV_FEATURE__OPCM_V2", false);
Expand Down
4 changes: 0 additions & 4 deletions packages/contracts-bedrock/src/libraries/DevFeatures.sol
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,6 @@ library DevFeatures {
bytes32 public constant DEPLOY_V2_DISPUTE_GAMES =
bytes32(0x0000000000000000000000000000000000000000000000000000000000000100);

/// @notice The feature that enables the custom gas token.
bytes32 public constant CUSTOM_GAS_TOKEN =
bytes32(0x0000000000000000000000000000000000000000000000000000000000001000);

/// @notice The feature that enables the OPContractsManagerV2 contract.
bytes32 public constant OPCM_V2 = bytes32(0x0000000000000000000000000000000000000000000000000000000000010000);

Expand Down
5 changes: 0 additions & 5 deletions packages/contracts-bedrock/test/L1/FeesDepositor.t.sol
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import { FeesDepositor } from "src/L1/FeesDepositor.sol";
import { IProxyAdminOwnedBase } from "interfaces/L1/IProxyAdminOwnedBase.sol";
import { Proxy } from "src/universal/Proxy.sol";
import { Features } from "src/libraries/Features.sol";
import { DevFeatures } from "src/libraries/DevFeatures.sol";

/// @title FeesDepositor_TestInit
/// @notice Base test contract with initialization for `FeesDepositor` tests.
Expand Down Expand Up @@ -98,8 +97,6 @@ contract FeesDepositor_Receive_Test is FeesDepositor_TestInit {
}

function testFuzz_receive_atOrAboveThreshold_succeeds(uint256 _sendAmount) external {
skipIfDevFeatureEnabled(DevFeatures.CUSTOM_GAS_TOKEN);

// Handling the fork tests scenario case for the fork tests
uint256 depositFeesRecipientBalanceBefore = depositFeesRecipient.balance;
_sendAmount = bound(_sendAmount, minDepositAmount, type(uint256).max - depositFeesRecipientBalanceBefore);
Expand All @@ -126,8 +123,6 @@ contract FeesDepositor_Receive_Test is FeesDepositor_TestInit {
}

function testFuzz_receive_multipleDeposits_succeeds(uint256 _firstAmount, uint256 _secondAmount) external {
skipIfDevFeatureEnabled(DevFeatures.CUSTOM_GAS_TOKEN);

// Handling the fork tests scenario
uint256 depositFeesRecipientBalanceBefore = depositFeesRecipient.balance;
// First amount should not exceed minDepositAmount (so it doesn't trigger deposit)
Expand Down
8 changes: 0 additions & 8 deletions packages/contracts-bedrock/test/L1/L1StandardBridge.t.sol
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,6 @@ import { Predeploys } from "src/libraries/Predeploys.sol";
import { AddressAliasHelper } from "src/vendor/AddressAliasHelper.sol";
import { EIP1967Helper } from "test/mocks/EIP1967Helper.sol";
import { Features } from "src/libraries/Features.sol";
import { DevFeatures } from "src/libraries/DevFeatures.sol";

// Interfaces
import { ICrossDomainMessenger } from "interfaces/universal/ICrossDomainMessenger.sol";
Expand Down Expand Up @@ -333,7 +332,6 @@ contract L1StandardBridge_Paused_Test is CommonTest {
contract L1StandardBridge_Receive_Test is CommonTest {
/// @notice Tests receive bridges ETH successfully.
function test_receive_succeeds() external {
skipIfDevFeatureEnabled(DevFeatures.CUSTOM_GAS_TOKEN);
uint256 portalBalanceBefore = address(optimismPortal2).balance;
uint256 ethLockboxBalanceBefore = address(ethLockbox).balance;

Expand Down Expand Up @@ -388,7 +386,6 @@ contract L1StandardBridge_DepositETH_Test is L1StandardBridge_TestInit {
/// Only EOA can call depositETH.
/// ETH ends up in the optimismPortal.
function test_depositETH_fromEOA_succeeds() external {
skipIfDevFeatureEnabled(DevFeatures.CUSTOM_GAS_TOKEN);
_preBridgeETH({ isLegacy: true, value: 500 });
uint256 portalBalanceBefore = address(optimismPortal2).balance;
uint256 ethLockboxBalanceBefore = address(ethLockbox).balance;
Expand All @@ -404,7 +401,6 @@ contract L1StandardBridge_DepositETH_Test is L1StandardBridge_TestInit {

/// @notice Tests that depositing ETH succeeds for an EOA using 7702 delegation.
function test_depositETH_fromEOA7702_succeeds() external {
skipIfDevFeatureEnabled(DevFeatures.CUSTOM_GAS_TOKEN);
// Set alice to have 7702 code.
vm.etch(alice, abi.encodePacked(hex"EF0100", address(0)));

Expand Down Expand Up @@ -439,7 +435,6 @@ contract L1StandardBridge_DepositETHTo_Test is L1StandardBridge_TestInit {
/// EOA or contract can call depositETHTo.
/// ETH ends up in the optimismPortal.
function test_depositETHTo_succeeds() external {
skipIfDevFeatureEnabled(DevFeatures.CUSTOM_GAS_TOKEN);
_preBridgeETHTo({ isLegacy: true, value: 600 });
uint256 portalBalanceBefore = address(optimismPortal2).balance;
uint256 ethLockboxBalanceBefore = address(ethLockbox).balance;
Expand All @@ -457,7 +452,6 @@ contract L1StandardBridge_DepositETHTo_Test is L1StandardBridge_TestInit {
/// @param _to Random recipient address
/// @param _amount Random ETH amount to deposit
function testFuzz_depositETHTo_randomRecipient_succeeds(address _to, uint256 _amount) external {
skipIfDevFeatureEnabled(DevFeatures.CUSTOM_GAS_TOKEN);
vm.assume(_to != address(0));
_amount = bound(_amount, 1, 10 ether);

Expand Down Expand Up @@ -786,7 +780,6 @@ contract L1StandardBridge_Uncategorized_Test is L1StandardBridge_TestInit {
/// Only EOA can call bridgeETH.
/// ETH ends up in the optimismPortal.
function test_bridgeETH_succeeds() external {
skipIfDevFeatureEnabled(DevFeatures.CUSTOM_GAS_TOKEN);
_preBridgeETH({ isLegacy: false, value: 500 });
uint256 portalBalanceBefore = address(optimismPortal2).balance;
uint256 ethLockboxBalanceBefore = address(ethLockbox).balance;
Expand All @@ -806,7 +799,6 @@ contract L1StandardBridge_Uncategorized_Test is L1StandardBridge_TestInit {
/// Only EOA can call bridgeETHTo.
/// ETH ends up in the optimismPortal.
function test_bridgeETHTo_succeeds() external {
skipIfDevFeatureEnabled(DevFeatures.CUSTOM_GAS_TOKEN);
_preBridgeETHTo({ isLegacy: false, value: 600 });
uint256 portalBalanceBefore = address(optimismPortal2).balance;
uint256 ethLockboxBalanceBefore = address(ethLockbox).balance;
Expand Down
Loading