Skip to content

fix(scripts): validate interfaces and libraries in test artifact checking #18370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aliersh merged 1 commit into from
Nov 25, 2025
Merged

fix(scripts): validate interfaces and libraries in test artifact checking #18370

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/contracts-bedrock/scripts/checks/test-validation/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,10 @@ func testContractExistsInFile(testFilePath, contractName string) bool {
return false
}

return strings.Contains(string(content), "contract "+contractName)
contentStr := string(content)
return strings.Contains(contentStr, "contract "+contractName) ||
strings.Contains(contentStr, "interface "+contractName) ||
strings.Contains(contentStr, "library "+contractName)
}

// Test name validation
Expand Down
8 changes: 7 additions & 1 deletion packages/contracts-bedrock/scripts/checks/test-validation/main_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ func TestTestContractExistsInFile(t *testing.T) {
defer cleanup()

_ = os.MkdirAll("test", 0755)
_ = os.WriteFile("test/Contract.t.sol", []byte("contract MyContract_Test {}\ncontract OtherContract {}"), 0644)
_ = os.WriteFile("test/Contract.t.sol", []byte("contract MyContract_Test {}\ninterface IHelper {}\nlibrary LibHelper {}"), 0644)

if testContractExistsInFile("", "MyContract_Test") {
t.Error("empty path should return false")
Expand All @@ -93,6 +93,12 @@ func TestTestContractExistsInFile(t *testing.T) {
if !testContractExistsInFile("test/Contract.t.sol", "MyContract_Test") {
t.Error("should find existing contract")
}
if !testContractExistsInFile("test/Contract.t.sol", "IHelper") {
t.Error("should find existing interface")
}
if !testContractExistsInFile("test/Contract.t.sol", "LibHelper") {
t.Error("should find existing library")
}
if testContractExistsInFile("test/Contract.t.sol", "NonExistent_Test") {
t.Error("should return false for non-existent contract")
}
Expand Down