Add style guide for manual getters on struct typed storage variables#18345
Merged
Add style guide for manual getters on struct typed storage variables#18345
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #18345 +/- ##
===========================================
+ Coverage 75.47% 80.42% +4.94%
===========================================
Files 189 134 -55
Lines 11233 7202 -4031
===========================================
- Hits 8478 5792 -2686
+ Misses 2611 1410 -1201
+ Partials 144 0 -144
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
mds1
approved these changes
Nov 21, 2025
32d6532 to
4ef9101
Compare
4ef9101 to
ad40cdb
Compare
ad40cdb to
c5937ad
Compare
c5937ad to
809d35f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a style guide documenting the ideal pattern for struct typed storage variables.