Skip to content

Add style guide for manual getters on struct typed storage variables#18345

Merged
maurelian merged 1 commit intodevelopfrom
jm/struct-var-style
Dec 9, 2025
Merged

Add style guide for manual getters on struct typed storage variables#18345
maurelian merged 1 commit intodevelopfrom
jm/struct-var-style

Conversation

@maurelian
Copy link
Copy Markdown
Contributor

Adds a style guide documenting the ideal pattern for struct typed storage variables.

@maurelian maurelian requested a review from a team as a code owner November 20, 2025 17:55
@maurelian maurelian requested a review from Ethnical November 20, 2025 17:55
@codecov
Copy link
Copy Markdown

codecov Bot commented Nov 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.42%. Comparing base (c15a2ef) to head (809d35f).
⚠️ Report is 10 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #18345      +/-   ##
===========================================
+ Coverage    75.47%   80.42%   +4.94%     
===========================================
  Files          189      134      -55     
  Lines        11233     7202    -4031     
===========================================
- Hits          8478     5792    -2686     
+ Misses        2611     1410    -1201     
+ Partials       144        0     -144     
Flag Coverage Δ
cannon-go-tests-64 ?
contracts-bedrock-tests 80.42% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 56 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@maurelian maurelian enabled auto-merge December 1, 2025 02:05
@maurelian maurelian force-pushed the jm/struct-var-style branch from 32d6532 to 4ef9101 Compare December 3, 2025 20:39
@maurelian maurelian added this pull request to the merge queue Dec 3, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Dec 3, 2025
@maurelian maurelian force-pushed the jm/struct-var-style branch from 4ef9101 to ad40cdb Compare December 4, 2025 17:56
@maurelian maurelian added this pull request to the merge queue Dec 4, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Dec 4, 2025
@maurelian maurelian added this pull request to the merge queue Dec 8, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Dec 8, 2025
@maurelian maurelian force-pushed the jm/struct-var-style branch from ad40cdb to c5937ad Compare December 8, 2025 16:46
@maurelian maurelian force-pushed the jm/struct-var-style branch from c5937ad to 809d35f Compare December 8, 2025 20:18
@maurelian maurelian added this pull request to the merge queue Dec 9, 2025
Merged via the queue into develop with commit 1279fec Dec 9, 2025
170 checks passed
@maurelian maurelian deleted the jm/struct-var-style branch December 9, 2025 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants