Skip to content

Recommended a Safe fallback owner #18239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JosepBove merged 1 commit into from
Nov 12, 2025
Merged

Recommended a Safe fallback owner #18239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/contracts-bedrock/snapshots/semver-lock.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,8 +224,8 @@
"sourceCodeHash": "0x7fc4789b082bc8ecd29c4c75a06058f0ff0b72f1c1028a42db6f1c35269c8865"
},
"src/safe/SaferSafes.sol:SaferSafes": {
"initCodeHash": "0x80f67f25659b54347cea5f8c250cdf66a32a647375b6703e790b05965fe9cf88",
"sourceCodeHash": "0x9edb7350f8c664964dc106a89e1a117ba9e9b2d2c52d57b3c1c976170a34aa3b"
"initCodeHash": "0x0ad1f0f33517132b06a225b51e6eac48904d4ad691e0045eb70244d811d0d99d",
"sourceCodeHash": "0xd6683fe9be4019d34249ada5a4de3e597f1bd9cd473a89f6eff8f749a0b0e978"
},
"src/universal/OptimismMintableERC20.sol:OptimismMintableERC20": {
"initCodeHash": "0x3c85eed0d017dca8eda6396aa842ddc12492587b061e8c756a8d32c4610a9658",
Expand Down
9 changes: 9 additions & 0 deletions packages/contracts-bedrock/src/safe/LivenessModule2.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -165,6 +165,8 @@ abstract contract LivenessModule2 {
/// @notice Configures the module for a Safe that has already enabled it.
/// @param _config The configuration parameters for the module containing the response
/// period and fallback owner.
/// @dev It is strongly recommended that the fallback owner is also a Safe or at least a
/// contract that is capable of building and executing transaction batches.
function configureLivenessModule(ModuleConfig memory _config) external {
Safe callingSafe = Safe(payable(msg.sender));

Expand Down Expand Up @@ -357,6 +359,13 @@ abstract contract LivenessModule2 {
// even if it is not the SaferSafes guard. This is intentional, as it is possible that the
// guard was the cause of the liveness failure which resulted in the transfer of ownership to
// the fallback owner.
// WARNING: Removing the TimelockGuard from a Safe will make all Scheduled and Cancelled
// transactions at or below the Safe nonce immediately executable by anyone. To avoid this,
// particularly in an adversarial environment, it is recommended that the fallback owner is
// also a Safe, and that the call to `changeOwnershipToFallback` is the first transaction
// in a batch that also includes as many nonce-bumping no-op transactions through the Safe
// with the TimelockGuard as needed to increase its nonce above that of all Scheduled and
// Cancelled transactions.
_safe.execTransactionFromModule({
to: address(_safe),
value: 0,
Expand Down
4 changes: 2 additions & 2 deletions packages/contracts-bedrock/src/safe/SaferSafes.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,8 @@ import { ISemver } from "interfaces/universal/ISemver.sol";
/// compatibility restrictions in the LivenessModule2 and TimelockGuard contracts.
contract SaferSafes is LivenessModule2, TimelockGuard, ISemver {
/// @notice Semantic version.
/// @custom:semver 1.10.0
string public constant version = "1.10.0";
/// @custom:semver 1.10.1
string public constant version = "1.10.1";

/// @notice Error for when the liveness response period is insufficient.
error SaferSafes_InsufficientLivenessResponsePeriod();
Expand Down