Add CHAINID #182
Merged
Add CHAINID #182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willmeister
approved these changes
Jul 10, 2020
|
|
||
| // overwrite call params | ||
| let result := mload(0x40) | ||
| let success := call(gas, addr, 0, callBytes, calldatasize, result, 500000) |
There was a problem hiding this comment.
Looks like there are still a lot of remnants from the old hacky way that I missed in updates, but IIRC the last param to call should be 0 instead of that arbitrarily large number.
| let success := call(gas, addr, 0, callBytes, calldatasize, result, 500000) | ||
|
|
||
| if eq(success, 0) { | ||
| revert(0, 0) |
There was a problem hiding this comment.
This is just a test, so might not matter, but in general, I think we'll want to revert(result, returndatasize).
snario
pushed a commit
that referenced
this pull request
Apr 14, 2021
Bumps [ini](https://github.com/isaacs/ini) from 1.3.5 to 1.3.8. - [Release notes](https://github.com/isaacs/ini/releases) - [Commits](npm/ini@v1.3.5...v1.3.8) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Karl Floersch <[email protected]>
protolambda
pushed a commit
to protolambda/optimism
that referenced
this pull request
May 1, 2022
shenkeyao
referenced
this pull request
in EspressoSystems/optimism-espresso-integration
Mar 1, 2025
* state-migration: Read totalSupply directly from storage * Added trigger for updated dependencies * Removen token bindings --------- Co-authored-by: Javier Cortejoso <[email protected]>
QuentinI
referenced
this pull request
in EspressoSystems/optimism-espresso-integration
Mar 7, 2025
* state-migration: Read totalSupply directly from storage * Added trigger for updated dependencies * Removen token bindings --------- Co-authored-by: Javier Cortejoso <[email protected]>
theochap
pushed a commit
that referenced
this pull request
Dec 10, 2025
…182) * fix(primitives): use decode_2718() to gracefully handle the tx type * nit: space
Zena-park
added a commit
to tokamak-network/optimism
that referenced
this pull request
Dec 30, 2025
Zena-park
added a commit
to tokamak-network/optimism
that referenced
this pull request
Dec 30, 2025
theochap
pushed a commit
that referenced
this pull request
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Transpiles CHAINID to a call to ovmCHAINID in the Execution Manager, which simply returns 108. Also removes CHAINID from the Safety Checker whitelist mask.
Metadata
Fixes
Contributing Agreement